Skip to content

Commit d8ee749

Browse files
author
Dikshita Agarwal
committed
FROMLIST: media: iris: Add handling for no show frames
Firmware sends the picture type as NO_SHOW for frames which are not supposed to be displayed, add handling for the same in driver to drop them. Link: https://lore.kernel.org/linux-arm-msm/20250509-video-iris-hevc-vp9-v5-18-59b4ff7d331c@quicinc.com/ Acked-by: Vikash Garodia <quic_vgarodia@quicinc.com> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8550-QRD Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8550-HDK Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8650-QRD Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8650-HDK Tested-by: Vikash Garodia <quic_vgarodia@quicinc.com> # on sa8775p-ride Signed-off-by: Dikshita Agarwal <quic_dikshita@quicinc.com>
1 parent ef18b36 commit d8ee749

2 files changed

Lines changed: 4 additions & 1 deletion

File tree

drivers/media/platform/qcom/iris/iris_hfi_gen2_defines.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,7 @@ enum hfi_picture_type {
113113
HFI_PICTURE_I = 0x00000008,
114114
HFI_PICTURE_CRA = 0x00000010,
115115
HFI_PICTURE_BLA = 0x00000020,
116+
HFI_PICTURE_NOSHOW = 0x00000040,
116117
};
117118

118119
enum hfi_buffer_type {

drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,9 @@ static int iris_hfi_gen2_get_driver_buffer_flags(struct iris_inst *inst, u32 hfi
9191
struct iris_inst_hfi_gen2 *inst_hfi_gen2 = to_iris_inst_hfi_gen2(inst);
9292
u32 driver_flags = 0;
9393

94-
if (inst_hfi_gen2->hfi_frame_info.picture_type & keyframe)
94+
if (inst_hfi_gen2->hfi_frame_info.picture_type & HFI_PICTURE_NOSHOW)
95+
driver_flags |= V4L2_BUF_FLAG_ERROR;
96+
else if (inst_hfi_gen2->hfi_frame_info.picture_type & keyframe)
9597
driver_flags |= V4L2_BUF_FLAG_KEYFRAME;
9698
else if (inst_hfi_gen2->hfi_frame_info.picture_type & HFI_PICTURE_P)
9799
driver_flags |= V4L2_BUF_FLAG_PFRAME;

0 commit comments

Comments
 (0)