Skip to content

Commit 9a754f9

Browse files
lumagYongxing Mou
authored andcommitted
FROMLIST: drm/bridge: display-connector: don't autoenable HPD IRQ
If HPD IRQ is enabled in the display_connector's probe, it can be triggered too early, before the DRM connector is completely setup. Use the enable_hpd / disable_hpd callbacks to control enablement of the HPD IRQ. Fixes: 0c275c3 ("drm/bridge: Add bridge driver for display connectors") Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> Link: https://lore.kernel.org/all/20260314-dp-connector-hpd-v1-1-786044cedc17@oss.qualcomm.com/
1 parent 84a45dc commit 9a754f9

1 file changed

Lines changed: 17 additions & 0 deletions

File tree

drivers/gpu/drm/bridge/display-connector.c

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,20 @@ display_connector_bridge_detect(struct drm_bridge *bridge, struct drm_connector
8787
return display_connector_detect(bridge);
8888
}
8989

90+
static void display_connector_hpd_enable(struct drm_bridge *bridge)
91+
{
92+
struct display_connector *conn = to_display_connector(bridge);
93+
94+
enable_irq(conn->hpd_irq);
95+
}
96+
97+
static void display_connector_hpd_disable(struct drm_bridge *bridge)
98+
{
99+
struct display_connector *conn = to_display_connector(bridge);
100+
101+
disable_irq(conn->hpd_irq);
102+
}
103+
90104
static const struct drm_edid *display_connector_edid_read(struct drm_bridge *bridge,
91105
struct drm_connector *connector)
92106
{
@@ -178,6 +192,8 @@ static u32 *display_connector_get_input_bus_fmts(struct drm_bridge *bridge,
178192
static const struct drm_bridge_funcs display_connector_bridge_funcs = {
179193
.attach = display_connector_attach,
180194
.detect = display_connector_bridge_detect,
195+
.hpd_enable = display_connector_hpd_enable,
196+
.hpd_disable = display_connector_hpd_disable,
181197
.edid_read = display_connector_edid_read,
182198
.atomic_get_output_bus_fmts = display_connector_get_output_bus_fmts,
183199
.atomic_get_input_bus_fmts = display_connector_get_input_bus_fmts,
@@ -307,6 +323,7 @@ static int display_connector_probe(struct platform_device *pdev)
307323
NULL, display_connector_hpd_irq,
308324
IRQF_TRIGGER_RISING |
309325
IRQF_TRIGGER_FALLING |
326+
IRQF_NO_AUTOEN |
310327
IRQF_ONESHOT,
311328
"HPD", conn);
312329
if (ret) {

0 commit comments

Comments
 (0)