Skip to content

Commit d1f7991

Browse files
Kriskura176767Yuanjie Yang
authored andcommitted
Revert "FROMLIST: arm64: dts: qcom: talos: Flatten usb controller nodes"
This reverts commit 94c4503. Reason for revert: compilation issue due to mismatch of USB phy node. Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
1 parent 7fa26b6 commit d1f7991

3 files changed

Lines changed: 65 additions & 46 deletions

File tree

arch/arm64/boot/dts/qcom/qcs615-ride.dts

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -670,11 +670,13 @@
670670
};
671671

672672
&usb_1 {
673-
dr_mode = "peripheral";
674-
675673
status = "okay";
676674
};
677675

676+
&usb_1_dwc3 {
677+
dr_mode = "peripheral";
678+
};
679+
678680
&usb_2_hsphy {
679681
vdd-supply = <&vreg_l5a>;
680682
vdda-pll-supply = <&vreg_l12a>;
@@ -684,11 +686,13 @@
684686
};
685687

686688
&usb_2 {
687-
dr_mode = "host";
688-
689689
status = "okay";
690690
};
691691

692+
&usb_2_dwc3 {
693+
dr_mode = "host";
694+
};
695+
692696
&ufs_mem_hc {
693697
reset-gpios = <&tlmm 123 GPIO_ACTIVE_LOW>;
694698
vcc-supply = <&vreg_l17a>;

arch/arm64/boot/dts/qcom/talos-evk-som.dtsi

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -555,11 +555,13 @@
555555
*/
556556

557557
&usb_1 {
558-
dr_mode = "host";
559-
560558
status = "okay";
561559
};
562560

561+
&usb_1_dwc3 {
562+
dr_mode = "host";
563+
};
564+
563565
&usb_1_hsphy {
564566
vdd-supply = <&vreg_l5a>;
565567
vdda-pll-supply = <&vreg_l12a>;
@@ -569,11 +571,13 @@
569571
};
570572

571573
&usb_2 {
572-
dr_mode = "host";
573-
574574
status = "okay";
575575
};
576576

577+
&usb_2_dwc3 {
578+
dr_mode = "host";
579+
};
580+
577581
&usb_2_hsphy {
578582
vdd-supply = <&vreg_l5a>;
579583
vdda-pll-supply = <&vreg_l12a>;

arch/arm64/boot/dts/qcom/talos.dtsi

Lines changed: 49 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -4956,9 +4956,9 @@
49564956
status = "disabled";
49574957
};
49584958

4959-
usb_1: usb@a600000 {
4960-
compatible = "qcom,qcs615-dwc3", "qcom,snps-dwc3";
4961-
reg = <0x0 0x0a600000 0x0 0xfc100>;
4959+
usb_1: usb@a6f8800 {
4960+
compatible = "qcom,qcs615-dwc3", "qcom,dwc3";
4961+
reg = <0x0 0x0a6f8800 0x0 0x400>;
49624962

49634963
clocks = <&gcc GCC_CFG_NOC_USB3_PRIM_AXI_CLK>,
49644964
<&gcc GCC_USB30_PRIM_MASTER_CLK>,
@@ -4977,47 +4977,52 @@
49774977
<&gcc GCC_USB30_PRIM_MASTER_CLK>;
49784978
assigned-clock-rates = <19200000>, <200000000>;
49794979

4980-
interrupts-extended = <&intc GIC_SPI 133 IRQ_TYPE_LEVEL_HIGH 0>,
4981-
<&intc GIC_SPI 130 IRQ_TYPE_LEVEL_HIGH 0>,
4980+
interrupts-extended = <&intc GIC_SPI 130 IRQ_TYPE_LEVEL_HIGH 0>,
49824981
<&intc GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH 0>,
49834982
<&pdc 9 IRQ_TYPE_EDGE_BOTH>,
49844983
<&pdc 8 IRQ_TYPE_EDGE_BOTH>,
49854984
<&pdc 6 IRQ_TYPE_LEVEL_HIGH>;
4986-
interrupt-names = "dwc_usb3",
4987-
"pwr_event",
4985+
interrupt-names = "pwr_event",
49884986
"hs_phy_irq",
49894987
"dp_hs_phy_irq",
49904988
"dm_hs_phy_irq",
49914989
"ss_phy_irq";
49924990

4993-
iommus = <&apps_smmu 0x140 0x0>;
49944991
power-domains = <&gcc USB30_PRIM_GDSC>;
49954992
required-opps = <&rpmhpd_opp_nom>;
49964993

4997-
phys = <&usb_hsphy_1>, <&usb_qmpphy>;
4998-
phy-names = "usb2-phy", "usb3-phy";
4999-
50004994
resets = <&gcc GCC_USB30_PRIM_BCR>;
50014995

50024996
#address-cells = <2>;
50034997
#size-cells = <2>;
50044998
ranges;
50054999

5006-
snps,dis-u1-entry-quirk;
5007-
snps,dis-u2-entry-quirk;
5008-
snps,dis_u2_susphy_quirk;
5009-
snps,dis_u3_susphy_quirk;
5010-
snps,dis_enblslpm_quirk;
5011-
snps,has-lpm-erratum;
5012-
snps,hird-threshold = /bits/ 8 <0x10>;
5013-
snps,usb3_lpm_capable;
5014-
50155000
status = "disabled";
5001+
5002+
usb_1_dwc3: usb@a600000 {
5003+
compatible = "snps,dwc3";
5004+
reg = <0x0 0x0a600000 0x0 0xcd00>;
5005+
5006+
iommus = <&apps_smmu 0x140 0x0>;
5007+
interrupts = <GIC_SPI 133 IRQ_TYPE_LEVEL_HIGH 0>;
5008+
5009+
phys = <&usb_1_hsphy>, <&usb_qmpphy>;
5010+
phy-names = "usb2-phy", "usb3-phy";
5011+
5012+
snps,dis-u1-entry-quirk;
5013+
snps,dis-u2-entry-quirk;
5014+
snps,dis_u2_susphy_quirk;
5015+
snps,dis_u3_susphy_quirk;
5016+
snps,dis_enblslpm_quirk;
5017+
snps,has-lpm-erratum;
5018+
snps,hird-threshold = /bits/ 8 <0x10>;
5019+
snps,usb3_lpm_capable;
5020+
};
50165021
};
50175022

5018-
usb_2: usb@a800000 {
5019-
compatible = "qcom,qcs615-dwc3", "qcom,snps-dwc3";
5020-
reg = <0x0 0x0a800000 0x0 0xfc100>;
5023+
usb_2: usb@a8f8800 {
5024+
compatible = "qcom,qcs615-dwc3", "qcom,dwc3";
5025+
reg = <0x0 0x0a8f8800 0x0 0x400>;
50215026

50225027
clocks = <&gcc GCC_CFG_NOC_USB2_SEC_AXI_CLK>,
50235028
<&gcc GCC_USB20_SEC_MASTER_CLK>,
@@ -5036,24 +5041,18 @@
50365041
<&gcc GCC_USB20_SEC_MASTER_CLK>;
50375042
assigned-clock-rates = <19200000>, <200000000>;
50385043

5039-
interrupts-extended = <&intc GIC_SPI 664 IRQ_TYPE_LEVEL_HIGH 0>,
5040-
<&intc GIC_SPI 663 IRQ_TYPE_LEVEL_HIGH 0>,
5044+
interrupts-extended = <&intc GIC_SPI 663 IRQ_TYPE_LEVEL_HIGH 0>,
50415045
<&intc GIC_SPI 662 IRQ_TYPE_LEVEL_HIGH 0>,
50425046
<&pdc 11 IRQ_TYPE_EDGE_BOTH>,
50435047
<&pdc 10 IRQ_TYPE_EDGE_BOTH>;
5044-
interrupt-names = "dwc_usb3",
5045-
"pwr_event",
5048+
interrupt-names = "pwr_event",
50465049
"hs_phy_irq",
50475050
"dp_hs_phy_irq",
50485051
"dm_hs_phy_irq";
50495052

5050-
iommus = <&apps_smmu 0xe0 0x0>;
50515053
power-domains = <&gcc USB20_SEC_GDSC>;
50525054
required-opps = <&rpmhpd_opp_nom>;
50535055

5054-
phys = <&usb_hsphy_2>;
5055-
phy-names = "usb2-phy";
5056-
50575056
resets = <&gcc GCC_USB20_SEC_BCR>;
50585057

50595058
qcom,select-utmi-as-pipe-clk;
@@ -5062,14 +5061,26 @@
50625061
#size-cells = <2>;
50635062
ranges;
50645063

5065-
snps,dis_u2_susphy_quirk;
5066-
snps,dis_u3_susphy_quirk;
5067-
snps,dis_enblslpm_quirk;
5068-
snps,has-lpm-erratum;
5069-
snps,hird-threshold = /bits/ 8 <0x10>;
5070-
maximum-speed = "high-speed";
5071-
50725064
status = "disabled";
5065+
5066+
usb_2_dwc3: usb@a800000 {
5067+
compatible = "snps,dwc3";
5068+
reg = <0x0 0x0a800000 0x0 0xcd00>;
5069+
5070+
iommus = <&apps_smmu 0xe0 0x0>;
5071+
interrupts = <GIC_SPI 664 IRQ_TYPE_LEVEL_HIGH 0>;
5072+
5073+
phys = <&usb_2_hsphy>;
5074+
phy-names = "usb2-phy";
5075+
5076+
snps,dis_u2_susphy_quirk;
5077+
snps,dis_u3_susphy_quirk;
5078+
snps,dis_enblslpm_quirk;
5079+
snps,has-lpm-erratum;
5080+
snps,hird-threshold = /bits/ 8 <0x10>;
5081+
5082+
maximum-speed = "high-speed";
5083+
};
50735084
};
50745085

50755086
tsens0: thermal-sensor@c263000 {

0 commit comments

Comments
 (0)