Remove offset listeners, they are not used

Author: ufleisch

taglib/matroska/matroskaelement.cpp

@@ -37,7 +37,6 @@ class Matroska::Element::ElementPrivate
   ID id = 0;
   ByteVector data;
   List<Element *> sizeListeners;
-  List<Element *> offsetListeners;
   // The default write() implementation will delete an unrendered element,
   // therefore rendering is required by default and needs to be explicitly set
   // using setNeedsRender(false) together with overriding the write() method.
@@ -101,16 +100,6 @@ void Matroska::Element::addSizeListeners(const List<Element *> &elements)
   e->sizeListeners.append(elements);
 }
 
-void Matroska::Element::addOffsetListener(Element *element)
-{
-  e->offsetListeners.append(element);
-}
-
-void Matroska::Element::addOffsetListeners(const List<Element *> &elements)
-{
-  e->offsetListeners.append(elements);
-}
-
 void Matroska::Element::setID(ID id)
 {
   e->id = id;
@@ -154,23 +143,13 @@ bool Matroska::Element::emitSizeChanged(offset_t delta)
   return true;
 }
 
-bool Matroska::Element::emitOffsetChanged(offset_t delta)
-{
-  for(auto element : e->offsetListeners) {
-    if(!element->offsetChanged(*this, delta))
-      return false;
-  }
-  return true;
-}
-
 bool Matroska::Element::sizeChanged(Element &caller, offset_t delta)
 {
   // The equal case is needed when multiple new elements are added
   // (e.g. Attachments and Tags), they will start with the same offset
   // are updated via size change handling.
   if(caller.offset() <= e->offset && caller.id() != e->id) {
     e->offset += delta;
-    //return emitOffsetChanged(delta);
   }
   return true;
 }
@@ -181,12 +160,6 @@ offset_t Matroska::Element::sizeRenderedOrWritten() const
   return dataSize != 0 ? dataSize : e->size;
 }
 
-bool Matroska::Element::offsetChanged(Element &, offset_t)
-{
-  // Most elements don't need to handle this
-  return true;
-}
-
 void Matroska::Element::write(File &file)
 {
   file.insert(e->data, e->offset, e->size);

taglib/matroska/matroskaelement.h

@@ -53,12 +53,7 @@ namespace TagLib {
       virtual void write(TagLib::File &file);
       void addSizeListener(Element *element);
       void addSizeListeners(const List<Element *> &elements);
-      void addOffsetListener(Element *element);
-      void addOffsetListeners(const List<Element *> &elements);
-      //virtual void updatePosition(Element &caller, offset_t delta) = 0;
       bool emitSizeChanged(offset_t delta);
-      bool emitOffsetChanged(offset_t delta);
-      virtual bool offsetChanged(Element &caller, offset_t delta);
       virtual bool sizeChanged(Element &caller, offset_t delta);
 
     protected:

taglib/matroska/matroskaseekhead.h

@@ -39,7 +39,6 @@ namespace TagLib {
       void addEntry(ID id, offset_t offset);
       void write(TagLib::File &file) override;
       void sort();
-      //bool offsetChanged(Element &caller, offset_t delta) override;
       bool sizeChanged(Element &caller, offset_t delta) override;
 
     private: