Reject failed webapp existence checks.

Author: filiplajszczak

pythonanywhere_core/webapp.py

@@ -51,6 +51,7 @@ def sanity_checks(self, nuke: bool) -> None:
         :param nuke: if True, skip the check for existing webapp
 
         :raises SanityException: if API token is missing or webapp already exists
+        :raises PythonAnywhereApiException: if the existence check returns neither 200 nor 404
         """
         token = os.environ.get("API_TOKEN")
         if not token:
@@ -73,6 +74,11 @@ def sanity_checks(self, nuke: bool) -> None:
                 f"You already have a webapp for {self.domain}.\n\nUse the --nuke option if you want to replace it."
             )
 
+        if response.status_code != 404:
+            raise PythonAnywhereApiException(
+                f"GET to check webapp existence via API failed, got {response}:{response.text}"
+            )
+
     def create(self, python_version: str, virtualenv_path: Path | None, project_path: Path, nuke: bool) -> None:
         """Create a webapp for the given domain, using the given python version and virtualenv path
 

tests/test_webapp.py

@@ -88,9 +88,10 @@ def test_does_not_complain_if_api_token_exists(api_token, api_responses, domain_
     webapp.sanity_checks(nuke=False)  # should not raise
 
 
-def test_raises_if_no_api_token_exists(api_responses, no_api_token, webapp):
+@pytest.mark.parametrize("nuke", [False, True])
+def test_raises_if_no_api_token_exists(api_responses, no_api_token, webapp, nuke):
     with pytest.raises(SanityException) as e:
-        webapp.sanity_checks(nuke=False)
+        webapp.sanity_checks(nuke=nuke)
     assert "Could not find your API token" in str(e.value)
 
 
@@ -114,6 +115,27 @@ def test_does_not_raise_if_no_webapp(api_token, api_responses, domain_url, webap
     webapp.sanity_checks(nuke=False)  # should not raise
 
 
+@pytest.mark.parametrize("status_code", [201, 202, 204, 403, 429, 500])
+@pytest.mark.parametrize("json_body", [False, True])
+def test_sanity_checks_raise_on_unexpected_status(
+    api_token, api_responses, domain_url, webapp, status_code, json_body
+):
+    body = "" if status_code == 204 else (
+        '{"detail": "Preflight failed"}' if json_body else "Preflight failed"
+    )
+    api_responses.add(
+        responses.GET, domain_url, status=status_code, body=body,
+        content_type="application/json" if json_body else "text/plain",
+    )
+
+    with pytest.raises(PythonAnywhereApiException) as exc:
+        webapp.sanity_checks(nuke=False)
+
+    assert str(status_code) in str(exc.value)
+    assert body in str(exc.value)
+    assert len(api_responses.calls) == 1
+
+
 def test_nuke_option_overrides_all_but_token_check(
     api_token, api_responses, domain, fake_home, virtualenvs_folder, webapp
 ):
@@ -122,6 +144,8 @@ def test_nuke_option_overrides_all_but_token_check(
 
     webapp.sanity_checks(nuke=True)  # should not raise
 
+    assert len(api_responses.calls) == 0
+
 
 # CREATE
 ## /api/v0/user/{username}/webapps/ : POST