Require HTTP 204 for scheduled task deletion.

Author: filiplajszczak

pythonanywhere_core/schedule.py

@@ -52,7 +52,8 @@ def delete(self, task_id: int) -> Literal[True]:
         """Deletes scheduled task by id.
 
         :param task_id: scheduled task to be deleted id number
-        :returns: True when API response is 204"""
+        :returns: True when API response is 204
+        :raises PythonAnywhereApiException: if the response is not HTTP 204"""
 
         result = call_api(
             f"{self.base_url}{task_id}/", "DELETE"
@@ -61,10 +62,9 @@ def delete(self, task_id: int) -> Literal[True]:
         if result.status_code == 204:
             return True
 
-        if not result.ok:
-            raise PythonAnywhereApiException(
-                f"DELETE via API on task {task_id} failed, got {result}: {result.text}"
-            )
+        raise PythonAnywhereApiException(
+            f"DELETE via API on task {task_id} failed, got {result}: {result.text}"
+        )
 
     def get_list(self) -> List[dict]:
         """Gets list of existing scheduled tasks.

tests/test_schedule.py

@@ -133,6 +133,21 @@ def test_deletes_task(api_token, api_responses, task_base_url):
     assert result is True
 
 
+@pytest.mark.parametrize("status_code", [200, 201, 202, 403, 404, 500])
+@pytest.mark.parametrize("body", ['{"detail": "Deletion failed"}', "Non-JSON error"])
+def test_delete_raises_unless_response_is_204(
+        api_token, api_responses, task_base_url, status_code, body
+):
+    api_responses.add(responses.DELETE, f"{task_base_url}42/", status=status_code, body=body)
+
+    with pytest.raises(PythonAnywhereApiException) as exc:
+        Schedule().delete(42)
+
+    assert str(status_code) in str(exc.value)
+    assert body in str(exc.value)
+    assert len(api_responses.calls) == 1
+
+
 def test_raises_because_attempt_to_delete_nonexisting_task(api_token, api_responses, task_base_url):
     body = '{"detail": "Not fount."}'
     api_responses.add(