Reject unexpected schedule creation statuses.

Author: filiplajszczak

pythonanywhere_core/schedule.py

@@ -1,4 +1,4 @@
-from typing import List, Optional
+from typing import List
 
 from typing_extensions import Literal
 
@@ -29,24 +29,24 @@ class Schedule:
 
     base_url: str = get_api_endpoint(username=get_username(), flavor="schedule")
 
-    def create(self, params: dict) -> Optional[dict]:
+    def create(self, params: dict) -> dict:
         """Creates new scheduled task using `params`.
 
         Params should be: command, enabled (True or False), interval (daily or
         hourly), hour (24h format) and minute.
 
         :param params: dictionary with required scheduled task specs
-        :returns: dictionary with created task specs"""
+        :returns: dictionary with created task specs on HTTP 201
+        :raises PythonAnywhereApiException: if the response is not HTTP 201"""
 
         result = call_api(self.base_url, "POST", json=params)
 
         if result.status_code == 201:
             return result.json()
 
-        if not result.ok:
-            raise PythonAnywhereApiException(
-                f"POST to set new task via API failed, got {result}: {result.text}"
-            )
+        raise PythonAnywhereApiException(
+            f"POST to set new task via API failed, got {result}: {result.text}"
+        )
 
     def delete(self, task_id: int) -> Literal[True]:
         """Deletes scheduled task by id.

tests/test_schedule.py

@@ -83,6 +83,28 @@ def test_creates_hourly_task(
     assert Schedule().create(hourly_task_params) == task_specs
 
 
+@pytest.mark.parametrize("status_code, body", [
+    (200, '{"task_id": 42}'),
+    (202, '{"status": "accepted"}'),
+    (204, ""),
+    (400, '{"detail": "Invalid task"}'),
+    (403, '{"detail": "Forbidden"}'),
+    (500, '{"detail": "Server error"}'),
+    (500, "Non-JSON server error"),
+])
+def test_create_raises_unless_response_is_201(
+        api_token, api_responses, task_base_url, daily_task_params, status_code, body
+):
+    api_responses.add(responses.POST, task_base_url, status=status_code, body=body)
+
+    with pytest.raises(PythonAnywhereApiException) as exc:
+        Schedule().create(daily_task_params)
+
+    assert str(status_code) in str(exc.value)
+    assert body in str(exc.value)
+    assert len(api_responses.calls) == 1
+
+
 def test_raises_because_missing_params(api_token, api_responses, task_base_url):
     body = (
         '{"interval":["This field is required."],"command":["This field is required."],'