Repository navigation
Commit 25a4525
committed
Address grievejia review comments on Never/NoReturn spec
- Use int instead of object as the non-Never witness (object is already
expected to not be a subtype of most things; int is more illuminating)
- Rephrase to avoid the too-strong 'No type other than Never' claim
(uninhabitable types like tuple[Never, int] are also subtypes of Never)
- Qualify all 'every type T' as 'every fully static type T' throughout
(the subtype relation is undefined for gradual types like Any)
- Replace list[Never] with Sequence[Never] in the covariant example
(list is invariant, so list[Never] is not assignable to list[int];
Sequence is covariant and correctly demonstrates the bottom-type behaviour)1 parent 498e503 commit 25a4525
1 file changed
Lines changed: 15 additions & 13 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
117 | 117 | | |
118 | 118 | | |
119 | 119 | | |
120 | | - | |
121 | | - | |
| 120 | + | |
| 121 | + | |
122 | 122 | | |
123 | | - | |
124 | | - | |
| 123 | + | |
| 124 | + | |
125 | 125 | | |
126 | | - | |
127 | | - | |
| 126 | + | |
| 127 | + | |
128 | 128 | | |
129 | 129 | | |
130 | 130 | | |
| |||
138 | 138 | | |
139 | 139 | | |
140 | 140 | | |
141 | | - | |
142 | | - | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
143 | 144 | | |
| 145 | + | |
144 | 146 | | |
145 | 147 | | |
146 | | - | |
| 148 | + | |
147 | 149 | | |
148 | 150 | | |
149 | 151 | | |
| |||
162 | 164 | | |
163 | 165 | | |
164 | 166 | | |
165 | | - | |
166 | | - | |
167 | | - | |
168 | | - | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
169 | 171 | | |
170 | 172 | | |
171 | 173 | | |
| |||
0 commit comments