[3.15] Revert backports merged during the 3.15.0 release freeze on 5 October (#158873)

Author: pablogsal

.github/workflows/build.yml

@@ -605,9 +605,6 @@ jobs:
         - check-name: Undefined behavior
           sanitizer: UBSan
           free-threading: false
-        - check-name: Memory
-          sanitizer: MSan
-          free-threading: false
     uses: ./.github/workflows/reusable-san.yml
     with:
       sanitizer: ${{ matrix.sanitizer }}

.github/workflows/reusable-san.yml

@@ -60,7 +60,7 @@ jobs:
             || ''
           }}
     - name: UBSan option setup
-      if: inputs.sanitizer == 'UBSan'
+      if: inputs.sanitizer != 'TSan'
       run: >-
         echo
         "UBSAN_OPTIONS=${SAN_LOG_OPTION}
@@ -69,20 +69,6 @@ jobs:
         >> "$GITHUB_ENV"
       env:
         SAN_LOG_OPTION: log_path=${{ github.workspace }}/san_log
-    - name: MSan option setup
-      if: inputs.sanitizer == 'MSan'
-      run: |
-        echo "MSAN_OPTIONS=${SAN_LOG_OPTION} allocator_may_return_null=1 handle_segv=0" >> "$GITHUB_ENV"
-        # MSan reports false positives for memory initialized by libraries
-        # that are not built with MSan, so disable modules that use them.
-        # _remote_debugging links to libzstd directly, but we unpoision the memory.
-        {
-          echo '*disabled*'
-          echo '_bz2 _ctypes _curses _curses_panel _dbm _decimal _gdbm _hashlib'
-          echo '_lzma _sqlite3 _ssl _tkinter _uuid _zstd readline zlib'
-        } > Modules/Setup.local
-      env:
-        SAN_LOG_OPTION: log_path=${{ github.workspace }}/san_log
     - name: Add ccache to PATH
       run: |
         echo "PATH=/usr/lib/ccache:$PATH" >> "$GITHUB_ENV"
@@ -107,8 +93,6 @@ jobs:
     # gh-157958: -O2 instead of the pydebug default -Og to avoid a clang 21
     # compile-time blowup on some interpreter files.
     # (https://github.com/llvm/llvm-project/issues/179695)
-    # MSan uses --with-assertions instead of --with-pydebug because its
-    # hooks on the Python memory allocators hide uninitialized reads.
     - name: Configure CPython
       run: >-
         ./configure
@@ -117,11 +101,9 @@ jobs:
         ${{
           inputs.sanitizer == 'TSan'
           && '--with-thread-sanitizer'
-          || inputs.sanitizer == 'MSan'
-          && '--with-memory-sanitizer'
           || '--with-undefined-behavior-sanitizer --with-strict-overflow'
         }}
-        ${{ inputs.sanitizer == 'MSan' && '--with-assertions' || '--with-pydebug' }}
+        --with-pydebug
         ${{ inputs.sanitizer == 'TSan' && '--with-openssl="$OPENSSL_DIR" --with-openssl-rpath=auto' || '' }}
         ${{ inputs.free-threading && '--disable-gil' || '' }}
     - name: Build CPython

Doc/using/configure.rst

@@ -1015,10 +1015,6 @@ Debug options
 
    Enable MemorySanitizer allocation error detector, ``msan`` (default is no).
 
-   MSan reports false positives for memory initialized by libraries that are
-   not built with MSan, so either build all dependencies with MSan or disable
-   the extension modules that use them in :file:`Modules/Setup.local`.
-
    .. versionadded:: 3.6
 
 .. option:: --with-undefined-behavior-sanitizer

Include/internal/pycore_interp_structs.h

@@ -219,7 +219,6 @@ struct gc_old_stats_buffer {
 struct gc_stats {
     struct gc_young_stats_buffer young;
     struct gc_old_stats_buffer old[2];
-    uint32_t update_seq;
 };
 
 struct _gc_runtime_state {

Include/pyport.h

@@ -554,7 +554,6 @@ extern "C" {
 #      define _Py_MEMORY_SANITIZER
 #      define _Py_NO_SANITIZE_MEMORY __attribute__((no_sanitize_memory))
 #      define _Py_MSAN_UNPOISON(PTR, SIZE)  (__msan_unpoison(PTR, SIZE))
-#      define _Py_MSAN_UNPOISON_STRING(STR)  (__msan_unpoison_string(STR))
 #    endif
 #  endif
 #  if __has_feature(address_sanitizer)
@@ -596,9 +595,6 @@ extern "C" {
 #ifndef _Py_MSAN_UNPOISON
 #  define _Py_MSAN_UNPOISON(PTR, SIZE)
 #endif
-#ifndef _Py_MSAN_UNPOISON_STRING
-#  define _Py_MSAN_UNPOISON_STRING(STR)
-#endif
 
 /* AIX has __bool__ redefined in it's system header file. */
 #if defined(_AIX) && defined(__bool__)

Lib/asyncio/tools.py

@@ -27,10 +27,6 @@ def __init__(
 # ─── indexing helpers ───────────────────────────────────────────
 def _format_stack_entry(elem: str|FrameInfo) -> str:
     if not isinstance(elem, str):
-        if elem.location is None:
-            if elem.filename in ("", "~"):
-                return f"{elem.funcname}"
-            return f"{elem.funcname} {elem.filename}"
         if elem.location.lineno == 0 and elem.filename == "":
             return f"{elem.funcname}"
         else:
@@ -194,7 +190,8 @@ def build_task_table(result):
             # Build coroutine stack string
             frames = [frame for coro in task_info.coroutine_stack
                      for frame in coro.call_stack]
-            coro_stack = " -> ".join(x.funcname for x in frames)
+            coro_stack = " -> ".join(_format_stack_entry(x).split(" ")[0]
+                                   for x in frames)
 
             # Handle tasks with no awaiters
             if not task_info.awaited_by:
@@ -205,7 +202,8 @@ def build_task_table(result):
             # Handle tasks with awaiters
             for coro_info in task_info.awaited_by:
                 parent_id = coro_info.task_name
-                awaiter_frames = [x.funcname for x in coro_info.call_stack]
+                awaiter_frames = [_format_stack_entry(x).split(" ")[0]
+                                for x in coro_info.call_stack]
                 awaiter_chain = " -> ".join(awaiter_frames)
                 awaiter_name = id2name.get(parent_id, "Unknown")
                 parent_id_str = (hex(parent_id) if isinstance(parent_id, int)

Lib/profiling/sampling/_sync_coordinator.py

@@ -168,11 +168,6 @@ def _execute_script(script_path: str, script_args: List[str], cwd: str) -> None:
     if not os.path.isfile(script_path):
         raise TargetError(f"Script not found: {script_path}")
 
-    script_dir = os.path.dirname(os.path.realpath(script_path))
-    if script_dir in sys.path:
-        sys.path.remove(script_dir)
-    sys.path.insert(0, script_dir)
-
     # Replace sys.argv to match original script call
     sys.argv = [script_path] + script_args
 

Lib/profiling/sampling/binary_collector.py

@@ -1,6 +1,5 @@
 """Thin Python wrapper around C binary writer for profiling data."""
 
-import sys
 import time
 
 import _remote_debugging
@@ -82,7 +81,6 @@ def __init__(self, filename, sample_interval_usec, *, skip_idle=False,
         self.filename = filename
         self.sample_interval_usec = sample_interval_usec
         self.skip_idle = skip_idle
-        self.running = True
 
         compression_type = _resolve_compression(compression)
         start_time_us = int(time.monotonic() * 1_000_000)
@@ -104,19 +102,9 @@ def collect(self, stack_frames, timestamp_us=None):
             timestamp_us: Optional timestamp in microseconds. If not provided,
                           uses time.monotonic() to generate one.
         """
-        if not self.running:
-            return
         if timestamp_us is None:
             timestamp_us = int(time.monotonic() * 1_000_000)
-        try:
-            self._writer.write_sample(stack_frames, timestamp_us)
-        except OverflowError as e:
-            if not self._writer.limit_reached:
-                raise
-            self.running = False
-            print(f"Warning: {e}; stopping early and keeping the data "
-                  "collected so far.",
-                  file=sys.stderr)
+        self._writer.write_sample(stack_frames, timestamp_us)
 
     def collect_failed_sample(self):
         """Record a failed sample attempt (no-op for binary format)."""
@@ -155,5 +143,9 @@ def __enter__(self):
         return self
 
     def __exit__(self, exc_type, exc_val, exc_tb):
-        """Finalize if the writer can still produce a valid file."""
-        return self._writer.__exit__(exc_type, exc_val, exc_tb)
+        """Context manager exit - finalize unless there was an error."""
+        if exc_type is None:
+            self._writer.finalize()
+        else:
+            self._writer.close()
+        return False

Lib/profiling/sampling/heatmap_collector.py

@@ -785,14 +785,14 @@ def _generate_file_html(self, output_path: Path, filename: str,
                           line_counts: Dict[int, int], self_counts: Dict[int, int],
                           file_stat: FileStats):
         """Generate HTML for a single source file with heatmap coloring."""
-        source_lines = [f"# Source file not available: {filename}"]
+        # Read source file
         try:
-            path = Path(filename)
-            if path.is_file():
-                source_lines = path.read_text(
-                    encoding='utf-8', errors='replace').splitlines()
-        except (IOError, OSError):
-            pass
+            source_lines = Path(filename).read_text(encoding='utf-8', errors='replace').splitlines()
+        except (IOError, OSError) as e:
+            if not (filename.startswith('<') or filename.startswith('[') or
+                    filename in ('~', '...', '.') or len(filename) < 2):
+                print(f"Warning: Could not read source file {filename}: {e}")
+            source_lines = [f"# Source file not available: {filename}"]
 
         # Generate HTML for each line
         max_samples = max(line_counts.values()) if line_counts else 1

Lib/profiling/sampling/stack_collector.py

@@ -60,18 +60,13 @@ def export(self, filename):
 
         lines.sort(key=lambda x: (-x[1], x[0]))
 
-        with open(filename, "w",
-                  encoding="utf-8", errors="surrogatepass") as f:
+        with open(filename, "w") as f:
             for stack, count in lines:
                 f.write(f"{stack} {count}\n")
         print(f"Collapsed stack output written to {filename}")
         return True
 
 
-# Bounded by the unwinder's maximum captured stack depth (MAX_FRAMES).
-_FLAMEGRAPH_RECURSION_MARGIN = 2000
-
-
 class FlamegraphCollector(StackTraceCollector):
     def __init__(self, *args, **kwargs):
         super().__init__(*args, **kwargs)
@@ -170,41 +165,34 @@ def set_mode(self, mode):
         self.stats["mode"] = mode
 
     def export(self, filename):
-        # Converting the call tree recurses to the sampled stack depth.
-        old_limit = sys.getrecursionlimit()
-        sys.setrecursionlimit(old_limit + _FLAMEGRAPH_RECURSION_MARGIN)
-        try:
-            flamegraph_data = self._convert_to_flamegraph_format()
-
-            # Debug output with string table statistics
-            num_functions = len(flamegraph_data.get("children", []))
-            total_time = flamegraph_data.get("value", 0)
-            string_count = len(self._string_table)
-            s1 = "" if num_functions == 1 else "s"
-            s2 = "" if total_time == 1 else "s"
-            s3 = "" if string_count == 1 else "s"
+        flamegraph_data = self._convert_to_flamegraph_format()
+
+        # Debug output with string table statistics
+        num_functions = len(flamegraph_data.get("children", []))
+        total_time = flamegraph_data.get("value", 0)
+        string_count = len(self._string_table)
+        s1 = "" if num_functions == 1 else "s"
+        s2 = "" if total_time == 1 else "s"
+        s3 = "" if string_count == 1 else "s"
+        print(
+            f"Flamegraph data: {num_functions} root function{s1}, "
+            f"{total_time} total sample{s2}, "
+            f"{string_count} unique string{s3}"
+        )
+
+        if num_functions == 0:
             print(
-                f"Flamegraph data: {num_functions} root function{s1}, "
-                f"{total_time} total sample{s2}, "
-                f"{string_count} unique string{s3}"
+                "Warning: No functions found in profiling data. Check if sampling captured any data."
             )
+            return False
 
-            if num_functions == 0:
-                print(
-                    "Warning: No functions found in profiling data. "
-                    "Check if sampling captured any data."
-                )
-                return False
-
-            html_content = self._create_flamegraph_html(flamegraph_data)
+        html_content = self._create_flamegraph_html(flamegraph_data)
 
-            with open(filename, "w", encoding="utf-8") as f:
-                f.write(html_content)
+        with open(filename, "w", encoding="utf-8") as f:
+            f.write(html_content)
 
-            print(f"Flamegraph saved to: {filename}")
-            return True
-        finally:
-            sys.setrecursionlimit(old_limit)
+        print(f"Flamegraph saved to: {filename}")
+        return True
 
     @staticmethod
     @functools.lru_cache(maxsize=None)