Skip to content

Commit 8f12499

Browse files
committed
gh-155648: In IDLE tests, call unittest.main without exit arg
In idlelib.idle_test, test_xyz.py files should end with ``` if __name__ == '__main__': unittest.main(verbosity=2, exit=0) ``` 5 files add the possibly confusing `exit=2` ("why?"), which is equivalent to the default `exit=True`. 4 files add `exit=False`. This is also nonsensical when there is nothing more to run; main will immediately exit anyway. When running the test from an IDLE editor, this argument has no visible effect. However, A Claude-based bug finder claims that in other circumstances (such as a program running the test in a shell), the good test may falsely fail. Even if this is not true, it can only confuse a reader.
1 parent ee4fe00 commit 8f12499

9 files changed

Lines changed: 9 additions & 9 deletions

File tree

‎Lib/idlelib/idle_test/test_delegator.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,4 +41,4 @@ def test_mydel(self):
4141

4242

4343
if __name__ == '__main__':
44-
unittest.main(verbosity=2, exit=2)
44+
unittest.main(verbosity=2)

‎Lib/idlelib/idle_test/test_format.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -665,4 +665,4 @@ def test_rstrip_end(self):
665665

666666

667667
if __name__ == '__main__':
668-
unittest.main(verbosity=2, exit=2)
668+
unittest.main(verbosity=2)

‎Lib/idlelib/idle_test/test_history.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,4 +169,4 @@ def test_history_prev_next(self):
169169

170170

171171
if __name__ == '__main__':
172-
unittest.main(verbosity=2, exit=2)
172+
unittest.main(verbosity=2)

‎Lib/idlelib/idle_test/test_pathbrowser.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,4 +83,4 @@ def test_PathBrowserTreeItem(self):
8383

8484

8585
if __name__ == '__main__':
86-
unittest.main(verbosity=2, exit=False)
86+
unittest.main(verbosity=2)

‎Lib/idlelib/idle_test/test_query.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -448,4 +448,4 @@ def test_click_args(self):
448448

449449

450450
if __name__ == '__main__':
451-
unittest.main(verbosity=2, exit=False)
451+
unittest.main(verbosity=2)

‎Lib/idlelib/idle_test/test_search.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,4 +77,4 @@ def test_find_selection(self):
7777
text.delete('2.0', 'end')
7878

7979
if __name__ == '__main__':
80-
unittest.main(verbosity=2, exit=2)
80+
unittest.main(verbosity=2)

‎Lib/idlelib/idle_test/test_searchbase.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,4 +157,4 @@ def test_create_command_buttons(self):
157157

158158

159159
if __name__ == '__main__':
160-
unittest.main(verbosity=2, exit=2)
160+
unittest.main(verbosity=2)

‎Lib/idlelib/idle_test/test_text.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,4 +233,4 @@ def setUp(self):
233233

234234

235235
if __name__ == '__main__':
236-
unittest.main(verbosity=2, exit=False)
236+
unittest.main(verbosity=2)

‎Lib/idlelib/idle_test/test_undo.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,4 +132,4 @@ def test_addcmd(self):
132132

133133

134134
if __name__ == '__main__':
135-
unittest.main(verbosity=2, exit=False)
135+
unittest.main(verbosity=2)

0 commit comments

Comments
 (0)