[3.14] gh-157892: Fix error check on _Py_hashtable_set() in intern_static() (GH-157898) (#158300)

gh-157892: Fix error check on _Py_hashtable_set() in intern_static() (GH-157898)

_Py_hashtable_set() returns -1 on failure, so the "< -1" check could never be true and the Py_FatalError() call was unreachable.
(cherry picked from commit a4eb936)

Co-authored-by: Rishi Raj <180109771+rishiraj38@users.noreply.github.com>
Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>

Author: 3 people

Objects/unicodeobject.c

@@ -15947,7 +15947,7 @@ intern_static(PyInterpreterState *interp, PyObject *s /* stolen */)
         return Py_NewRef(r);
     }
 
-    if (_Py_hashtable_set(INTERNED_STRINGS, s, s) < -1) {
+    if (_Py_hashtable_set(INTERNED_STRINGS, s, s) < 0) {
         Py_FatalError("failed to intern static string");
     }