From abe9d1c992d3a414221546487a424cd62e1a4efb Mon Sep 17 00:00:00 2001 From: Matijs van Zuijlen Date: Sun, 1 Nov 2026 13:01:53 +0100 Subject: [PATCH] Use consistent implementation of access check on feedback The existing code was a copy of the implementation of Article#access_by?, so use that instead. --- app/controllers/admin/feedback_controller.rb | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/controllers/admin/feedback_controller.rb b/app/controllers/admin/feedback_controller.rb index c589eb15..3036563c 100644 --- a/app/controllers/admin/feedback_controller.rb +++ b/app/controllers/admin/feedback_controller.rb @@ -58,8 +58,9 @@ def update def destroy @record = Feedback.find params[:id] - unless @record.article.user_id == current_user.id - return redirect_to admin_feedback_index_url unless current_user.admin? + unless @record.article.access_by? current_user + redirect_to admin_feedback_index_url + return end begin