Merge pull request #685 from uyjulian/iomanx_fd_lower_bounds_check

fjtrujy · web-flow · commit e3bea498c2b0 · 2024-11-29T08:58:01.000+01:00
iomanX perform lower bounds check on fd before returning
diff --git a/iop/system/iomanx/src/iomanX.c b/iop/system/iomanx/src/iomanX.c
@@ -979,7 +979,7 @@ static iomanX_iop_file_t *new_iob(void)
 
 static iomanX_iop_file_t *get_iob(int fd)
 {
-	if ( ((unsigned int)fd >= (sizeof(file_table) / sizeof(file_table[0]))) || (!file_table[fd].device) )
+	if ( (fd < 0) || ((unsigned int)fd >= (sizeof(file_table) / sizeof(file_table[0]))) || (!file_table[fd].device) )
 		return NULL;
 	return &file_table[fd];
 }

Original file line number	Diff line number	Diff line change
`@@ -979,7 +979,7 @@ static iomanX_iop_file_t *new_iob(void)`
`979`	`979`
`980`	`980`	`static iomanX_iop_file_t *get_iob(int fd)`
`981`	`981`	`{`
`982`		`- if ( ((unsigned int)fd >= (sizeof(file_table) / sizeof(file_table[0]))) \|\| (!file_table[fd].device) )`
	`982`	`+ if ( (fd < 0) \|\| ((unsigned int)fd >= (sizeof(file_table) / sizeof(file_table[0]))) \|\| (!file_table[fd].device) )`
`983`	`983`	`return NULL;`
`984`	`984`	`return &file_table[fd];`
`985`	`985`	`}`