Skip to content

Commit 5be1549

Browse files
committed
fix rebase of 1.13.1-rc2
Signed-off-by: Antonio Murdaca <runcom@redhat.com>
1 parent 657f798 commit 5be1549

2 files changed

Lines changed: 12 additions & 7 deletions

File tree

cli/command/plugin/install.go

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -98,11 +98,6 @@ func buildPullConfig(ctx context.Context, dockerCli *command.DockerCli, opts plu
9898
return types.PluginInstallOptions{}, err
9999
}
100100

101-
index, err := getRepoIndexFromUnnormalizedRef(ref)
102-
if err != nil {
103-
return types.PluginInstallOptions{}, err
104-
}
105-
106101
repoInfoIndex, err := getRepoIndexFromUnnormalizedRef(ref)
107102
if err != nil {
108103
return types.PluginInstallOptions{}, err
@@ -136,7 +131,7 @@ func buildPullConfig(ctx context.Context, dockerCli *command.DockerCli, opts plu
136131

137132
dockerRef, err := reference.ParseNamed(ref.Name())
138133
if err != nil {
139-
return err
134+
return types.PluginInstallOptions{}, err
140135
}
141136
encodedAuth, err := command.GetEncodedAuth(dockerCli, dockerRef)
142137
if err != nil {

plugin/backend_linux.go

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,10 +251,20 @@ func (pm *Manager) Upgrade(ctx context.Context, ref reference.Named, name string
251251
blobStore: pm.blobStore,
252252
}
253253

254+
repoInfo, err := registry.ParseRepositoryInfo(ref)
255+
if err != nil {
256+
return err
257+
}
258+
auths := make(map[string]types.AuthConfig)
259+
authConfigKey := registry.GetAuthConfigKey(repoInfo.Index)
260+
if authConfig != nil {
261+
auths[authConfigKey] = *authConfig
262+
}
263+
254264
pluginPullConfig := &distribution.ImagePullConfig{
255265
Config: distribution.Config{
256266
MetaHeaders: metaHeader,
257-
AuthConfig: authConfig,
267+
AuthConfigs: auths,
258268
RegistryService: pm.config.RegistryService,
259269
ImageEventLogger: pm.config.LogPluginEvent,
260270
ImageStore: dm,

0 commit comments

Comments
 (0)