Skip to content

Keyboard shortcuts modal is out of sync with actual keybindings #4253

Description

@NisargJasani0602

Follow-up to #4222 (see this comment for context) — KeyboardShortcutModal.jsx has drifted from what's actually wired up in keymaps.js. A few known discrepancies:

Advertised but not implemented:

  • The modal lists {Ctrl/Cmd}+H for "Replace," but there's no replace command wired up anywhere in keymaps.js. Worth deciding: implement it (CodeMirror 6's search panel already supports replace, just needs to be exposed on this shortcut), or remove the claim from the modal if it's not planned.

Implemented but not advertised:

  • Ctrl-Shift-Up/Down (Cmd-Ctrl-Up/Down on Mac) — move line up/down, added in Fix Ctrl+Shift+Up/Down no longer moving lines #4250.
  • Shift-Ctrl-D (Shift-Cmd-D on Mac) — duplicate line, and Ctrl-Up/Down (Ctrl-Alt-Up/Down on Mac) — scroll without moving cursor, both pending in a follow-up PR.

Proposal

  1. Decide the fate of the Replace shortcut (implement vs. remove from modal).
  2. Add entries to KeyboardShortcutModal.jsx for the shortcuts above.

Happy to take this on.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions