Skip to content

Cleanup the finding section#883

Merged
MakisH merged 9 commits into
masterfrom
update-finding-section
May 17, 2026
Merged

Cleanup the finding section#883
MakisH merged 9 commits into
masterfrom
update-finding-section

Conversation

@fsimonis
Copy link
Copy Markdown
Member

This PR cleans up the finding section.

  • I removed the warning about using from the build directory.
  • I changed the script to use conditional expansion, ${CPATH:+:$CPATH}, meaning if CPATH exists, evaluate to :$CPATH. Empty includes due to tailing : break compilers in super strange ways.
  • I added a statement on how to validate environment.d changes.
  • I added a section on how to verify the installation.

@fsimonis fsimonis requested a review from MakisH April 14, 2026 14:42
Copy link
Copy Markdown
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useful cleanup, useful section addition. Thanks!

Only some nitpicking comments (some outside the changes of this PR).

Comment thread content/docs/installation/building-from-source/installation-source-finding.md Outdated
Comment thread content/docs/installation/building-from-source/installation-source-finding.md Outdated
Comment thread content/docs/installation/building-from-source/installation-source-finding.md Outdated
Comment thread content/docs/installation/building-from-source/installation-source-finding.md Outdated
Comment thread content/docs/installation/building-from-source/installation-source-finding.md Outdated
@MakisH MakisH added the content Content-only issues label Apr 14, 2026
Copy link
Copy Markdown
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was rather straightforward, so I think it does not need to stay open any longer.

I applied my suggestions and a few more suggestions by LanguageTool. Good to go!

@MakisH MakisH merged commit 8430234 into master May 17, 2026
2 checks passed
@MakisH MakisH deleted the update-finding-section branch May 17, 2026 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content Content-only issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants