Skip to content

Commit b835770

Browse files
marvinhagemeisterForsakenHarmony
authored andcommitted
Stop spinner during installation (#849)
This allows npm and yarn to print their output to the cli. Previously warnings and errors would be swallowed by the spinner
1 parent 19b7e2c commit b835770

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

packages/cli/lib/commands/create.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,8 @@ module.exports = async function(repo, dest, argv) {
184184
// await fs.copyFile(serviceWorkerSrc, join(resolve(cwd, dest), 'src', 'sw.js'));
185185

186186
if (argv.install) {
187-
spinner.text = 'Installing dependencies';
187+
spinner.text = 'Installing dependencies:\n';
188+
spinner.stopAndPersist();
188189
await install(target, isYarn);
189190
}
190191

0 commit comments

Comments
 (0)