Use field size instead of relying on null termination in posted content. Closes #180

pramsey · pramsey · commit f826cfc02dd3 · 2024-09-16T08:53:27.000-07:00
diff --git a/http.c b/http.c
@@ -1224,7 +1224,8 @@ Datum http_request(PG_FUNCTION_ARGS)
 				CURL_SETOPT(g_http_handle, CURLOPT_CUSTOMREQUEST, "DELETE");
 			}
 
-			CURL_SETOPT(g_http_handle, CURLOPT_POSTFIELDS, text_to_cstring(content_text));
+			CURL_SETOPT(g_http_handle, CURLOPT_POSTFIELDS, (char *)(VARDATA(content_text)));
+			CURL_SETOPT(g_http_handle, CURLOPT_POSTFIELDSIZE, content_size);
 		}
 		else if ( method == HTTP_PUT || method == HTTP_PATCH || method == HTTP_UNKNOWN )
 		{

Original file line number	Diff line number	Diff line change
`@@ -1224,7 +1224,8 @@ Datum http_request(PG_FUNCTION_ARGS)`
`1224`	`1224`	`CURL_SETOPT(g_http_handle, CURLOPT_CUSTOMREQUEST, "DELETE");`
`1225`	`1225`	`}`
`1226`	`1226`
`1227`		`- CURL_SETOPT(g_http_handle, CURLOPT_POSTFIELDS, text_to_cstring(content_text));`
	`1227`	`+ CURL_SETOPT(g_http_handle, CURLOPT_POSTFIELDS, (char *)(VARDATA(content_text)));`
	`1228`	`+ CURL_SETOPT(g_http_handle, CURLOPT_POSTFIELDSIZE, content_size);`
`1228`	`1229`	`}`
`1229`	`1230`	`else if ( method == HTTP_PUT \|\| method == HTTP_PATCH \|\| method == HTTP_UNKNOWN )`
`1230`	`1231`	`{`