Skip to content

Commit 031da0f

Browse files
authored
Merge pull request #1487 from polywrap/fix/uri-resolver-ext-handle-null-result
fix: handle null return values from uri resolver extensions
2 parents 40eca83 + b08a86e commit 031da0f

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

packages/js/core/src/interfaces/uri-resolver.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ import { Tracer } from "@polywrap/tracing-js";
44
import { Result } from "@polywrap/result";
55

66
export interface MaybeUriOrManifest {
7-
uri?: string;
8-
manifest?: Uint8Array;
7+
uri?: string | null;
8+
manifest?: Uint8Array | null;
99
}
1010

1111
export const module = {
@@ -32,8 +32,8 @@ export const module = {
3232
invoker: Invoker,
3333
wrapper: Uri,
3434
path: string
35-
): Promise<Result<Uint8Array | undefined, WrapError>> => {
36-
return invoker.invoke<Uint8Array | undefined>({
35+
): Promise<Result<Uint8Array | null, WrapError>> => {
36+
return invoker.invoke<Uint8Array | null>({
3737
uri: wrapper.uri,
3838
method: "getFile",
3939
args: {

packages/js/uri-resolver-extensions/src/UriResolverExtensionFileReader.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ export class UriResolverExtensionFileReader implements IFileReader {
3434
path
3535
);
3636
if (!result.ok) return result;
37-
if (result.value === undefined) {
37+
if (!result.value) {
3838
return ResultErr(new Error(`File not found at ${path}`));
3939
}
4040
return {

0 commit comments

Comments
 (0)