feat: add tests for manifest

Author: Niraj-Kamdar

packages/polywrap-manifest/polywrap_manifest/deserialize.py

@@ -12,15 +12,15 @@
 
 
 def deserialize_wrap_manifest(
-    manifest: bytearray, options: Optional[DeserializeManifestOptions] = None
+    manifest: bytes, options: Optional[DeserializeManifestOptions] = None
 ) -> AnyWrapManifest:
     decoded_manifest = msgpack_decode(manifest)
     if not decoded_manifest.get("version"):
         raise ValueError("Expected manifest version to be defined!")
 
     no_validate = options and options.no_validate
     manifest_version = WrapManifestVersions(decoded_manifest["version"])
-    match manifest_version:
+    match manifest_version.value:
         case "0.1.0":
             return (
                 WrapManifest_0_1.construct(**decoded_manifest)

packages/polywrap-manifest/polywrap_manifest/manifest.py

@@ -7,9 +7,9 @@
 from dataclasses import dataclass
 from enum import Enum
 
-from wrap_0_1 import WrapManifest as WrapManifest_0_1
-from wrap_0_1 import Abi as WrapAbi_0_1_0_1
-from wrap_0_1 import *
+from .wrap_0_1 import WrapManifest as WrapManifest_0_1
+from .wrap_0_1 import Abi as WrapAbi_0_1_0_1
+from .wrap_0_1 import *
 
 
 @dataclass(slots=True, kw_only=True)

packages/polywrap-manifest/scripts/templates/manifest.py.jinja2

@@ -11,10 +11,10 @@ from typing import Union
 {%- endif %}
 
 {% for version in versions -%}
-from wrap_{{ version.manifest_module_version }} import WrapManifest as WrapManifest_{{ version.manifest_module_version }}
-from wrap_{{ version.manifest_module_version }} import Abi as WrapAbi_{{ version.manifest_module_version }}_{{ version.abi_module_version }}
+from .wrap_{{ version.manifest_module_version }} import WrapManifest as WrapManifest_{{ version.manifest_module_version }}
+from .wrap_{{ version.manifest_module_version }} import Abi as WrapAbi_{{ version.manifest_module_version }}_{{ version.abi_module_version }}
 {%- endfor %}
-from wrap_{{ latest.manifest_module_version }} import *
+from .wrap_{{ latest.manifest_module_version }} import *
 
 
 @dataclass(slots=True, kw_only=True)

packages/polywrap-manifest/tests/cases/simple/wrap.info

@@ -0,0 +1 @@
+��version�0.1�name�Simple�type�wasm�abi��version�0.1�moduleType��type�Module�kind̀�methods���name�simpleMethod�return��type�String�name�simpleMethod�requiredäkind"�scalar��name�simpleMethod�type�String�requiredäkind�type�Method�kind@�requiredéarguments���type�String�name�arg�requiredäkind"�scalar��name�arg�type�String�requiredäkind

packages/polywrap-manifest/tests/test_manifest.py

@@ -0,0 +1,66 @@
+import pytest
+from pathlib import Path
+from polywrap_manifest import (
+    deserialize_wrap_manifest,
+    WrapManifest_0_1,
+    DeserializeManifestOptions,
+)
+from pydantic import ValidationError
+from polywrap_msgpack import msgpack_encode, msgpack_decode
+
+
+@pytest.fixture
+def test_case_dir() -> Path:
+    return Path(__file__).parent / "cases"
+
+
+@pytest.fixture
+def msgpack_manifest(test_case_dir: Path) -> bytes:
+    with open(test_case_dir / "simple" / "wrap.info", "rb") as f:
+        return f.read()
+
+
+def test_deserialize_without_validate(msgpack_manifest: bytes):
+    deserialized = deserialize_wrap_manifest(msgpack_manifest, DeserializeManifestOptions(no_validate=True))
+    assert isinstance(deserialized, WrapManifest_0_1)
+    assert deserialized.version.value == "0.1"
+    assert deserialized.abi.version == "0.1"
+    assert deserialized.name == "Simple"
+
+
+def test_deserialize_with_validate(msgpack_manifest: bytes):
+    deserialized = deserialize_wrap_manifest(msgpack_manifest)
+    assert isinstance(deserialized, WrapManifest_0_1)
+    assert deserialized.version.value == "0.1"
+    assert deserialized.abi.version == "0.1"
+    assert deserialized.name == "Simple"
+
+
+def test_invalid_version(msgpack_manifest: bytes):
+    decoded = msgpack_decode(msgpack_manifest)
+    decoded["version"] = "bad-str"
+    manifest: bytes = msgpack_encode(decoded)
+
+    with pytest.raises(ValueError) as e:
+        deserialize_wrap_manifest(manifest)
+    assert e.match("'bad-str' is not a valid WrapManifestVersions")
+
+
+def test_unaccepted_field(msgpack_manifest: bytes):
+    decoded = msgpack_decode(msgpack_manifest)
+    decoded["invalid_field"] = "not allowed"
+    manifest: bytes = msgpack_encode(decoded)
+
+    with pytest.raises(ValidationError) as e:
+        deserialize_wrap_manifest(manifest)
+    assert e.match("extra fields not permitted")
+
+
+def test_invalid_name(msgpack_manifest: bytes):
+    decoded = msgpack_decode(msgpack_manifest)
+    decoded["name"] = "foo bar baz $%##$@#$@#$@#$#$",
+    manifest: bytes = msgpack_encode(decoded)
+
+    with pytest.raises(ValidationError) as e:
+        deserialize_wrap_manifest(manifest)
+    assert e.match("str type expected")