Add StringX methods for every PrintX method.

[lolbinarycat]

Currently there are a methods such as PrintSyntaxTree and PrettyPrintSyntaxTree. This is convenient if you want it printed to stdout, but not so much if you want to put it in a test log, or compare it's output for testing. There is WriteSyntaxTree, but that requires an io.Reader, so it's much less convenient.

I'm not 100% on the name though. One alternative would be Sprint, which is what the fmt package uses.
I can write the changes, but I'd like to get some feedback on the name first (although I might just write it and change the names later).

[lolbinarycat]

Alright, I don't get the build system. whenever I try to build with changes, it either fails, or succeeds but seemingly without my changes. It doesn't help that there's no -version flag, so I can't even tell what binary I'm running. The file I'm changing is tree/peg.go.

[theclapp]

WriteSyntaxTree is

func (t *tokens32) WriteSyntaxTree(w io.Writer, buffer string) {
	t.AST().Print(w, buffer)
}

To make it a string:

b := &bytes.Buffer{}
t.WriteSyntaxTree(b, buffer) // I'm unclear on what "buffer" is supposed to be, though.
return b.String()

So it's two more lines of code. That doesn't seem "much less" convenient to me. I'm not @pointlander , but can you elaborate on your problem?

[lolbinarycat]

@theclapp
Well, if err != nil {return err} is only 1-3 lines of code, but how many error checking proposals has go had?
That also doesn't factor in the fact that:

• you now have to import bytes or strings
• PrintSyntaxTree isn't the only "Print" method

As for my problem with the build system (which is what I assume you are referring to), I have many problems with it (like it shadowing the builtin delete function). I feel like I was fairly clear about my problem, so without a specific question, I don't know what to say.
If you're looking for the failing command output, here you go:

cd bootstrap
go build
cd /home/binarycat/go/src/github.com/lolbinarycat/peg
main.bootstrap
cd cmd/peg-bootstrap/
../../bootstrap/bootstrap
go build -tags bootstrap -o peg0
# github.com/pointlander/peg/cmd/peg-bootstrap
./bootstrap.peg.go:327:11: undefined: strings
cd /home/binarycat/go/src/github.com/lolbinarycat/peg
panic: exit status 2

goroutine 1 [running]:
main.command(0x4f7bf7, 0x2, 0x0, 0x0, 0x0, 0x0, 0xc0000cd440, 0x5, 0x5)
        /home/binarycat/go/src/github.com/lolbinarycat/peg/build.go:147 +0x5b0
main.peg0(0x4dd200)
        /home/binarycat/go/src/github.com/lolbinarycat/peg/build.go:193 +0x258
main.done(0x4fb155, 0x16, 0xc0000cd5f0, 0x2, 0x2, 0x594750)
        /home/binarycat/go/src/github.com/lolbinarycat/peg/build.go:79 +0x2ce
main.peg1(0x4dd200)
        /home/binarycat/go/src/github.com/lolbinarycat/peg/build.go:199 +0xc5
main.done(0x4fb16b, 0x16, 0xc0000cd7c0, 0x2, 0x2, 0x594808)
        /home/binarycat/go/src/github.com/lolbinarycat/peg/build.go:79 +0x2ce
main.peg2(0x4dd200)
        /home/binarycat/go/src/github.com/lolbinarycat/peg/build.go:214 +0xc5
main.done(0x4fb181, 0x16, 0xc0000cd990, 0x2, 0x2, 0x594890)
        /home/binarycat/go/src/github.com/lolbinarycat/peg/build.go:79 +0x2ce
main.peg3(0x4dd200)
        /home/binarycat/go/src/github.com/lolbinarycat/peg/build.go:229 +0xc5
main.done(0x4fd250, 0x1f, 0xc0000cdb60, 0x1, 0x1, 0x450300)
        /home/binarycat/go/src/github.com/lolbinarycat/peg/build.go:79 +0x2ce
main.peg_bootstrap(0x4dd200)
        /home/binarycat/go/src/github.com/lolbinarycat/peg/build.go:244 +0xa5
main.done(0x4f8c35, 0xa, 0xc0000cdd28, 0x1, 0x1, 0x638)
        /home/binarycat/go/src/github.com/lolbinarycat/peg/build.go:79 +0x2ce
main.peg_peg_go(0x4dd220)
        /home/binarycat/go/src/github.com/lolbinarycat/peg/build.go:259 +0x85
main.done(0x4f7c87, 0x3, 0xc0000cdeb8, 0x2, 0x2, 0x30)
        /home/binarycat/go/src/github.com/lolbinarycat/peg/build.go:79 +0x2ce
main.peg(0xc0000aa120)
        /home/binarycat/go/src/github.com/lolbinarycat/peg/build.go:271 +0x93
main.main()
        /home/binarycat/go/src/github.com/lolbinarycat/peg/build.go:31 +0xcc
exit status 2

[theclapp]

Thank you for the clarification. I was disagreeing with your characterization of two more lines of code as "much less" convenient. But it's okay to disagree, and it's certainly fine for you to ask for a feature you want.

Can't help you with your build problem. Works for me. Sorry. You said sometimes it works for you, so I won't post my output.

Thanks again for clarifying your dissatisfaction. I appreciate it.

[lolbinarycat]

Thank you for the clarification. I was disagreeing with your characterization of two more lines of code as "much less" convenient. But it's okay to disagree, and it's certainly fine for you to ask for a feature you want.

Can't help you with your build problem. Works for me. Sorry. You said sometimes it works for you, so I won't post my output.

Thanks again for clarifying your dissatisfaction. I appreciate it.

It works when I don't make changes, but that's not very helpful when I'm trying to change things. Also, basicly nothing is documented/commented, and what is is unhelpful at best.
Example (from bootstrap/main.go):

	/*package main

	  import "fmt"
	  import "math"
	  import "sort"
	  import "strconv"

	  type Peg Peg {
	   *Tree
	  }*/
	t.AddPackage("main")
	t.AddImport("github.com/pointlander/peg/tree")
	t.AddPeg("Peg")
	t.AddState(`
 *tree.Tree
`)

And why is everything named "peg". I had to run peg peg.peg, and that not even near the most confusing thing going on here.

[lolbinarycat]

Update: working build with SprintSyntaxTree method.

[dolmen]

@lolbinarycat #196 should improve the contributor's experience a little bit.