Skip to content

Downstream Core updates#1084

Merged
bouwew merged 3 commits into
mainfrom
downstream-170760
Jun 7, 2026
Merged

Downstream Core updates#1084
bouwew merged 3 commits into
mainfrom
downstream-170760

Conversation

@bouwew

@bouwew bouwew commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Documentation

    • Updated changelog with ongoing updates section and improved reference formatting.
  • Tests

    • Refactored and expanded configuration flow test suite with additional coverage for device discovery and abort scenarios.
    • Clarified test documentation and comments throughout test suite.

@coderabbitai

coderabbitai Bot commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d33bcdf0-62e3-48a4-b363-0c97f5c621f6

📥 Commits

Reviewing files that changed from the base of the PR and between c4754e0 and 5e177a9.

📒 Files selected for processing (5)
  • CHANGELOG.md
  • tests/components/plugwise/conftest.py
  • tests/components/plugwise/test_climate.py
  • tests/components/plugwise/test_config_flow.py
  • tests/components/plugwise/test_select.py

📝 Walkthrough

Walkthrough

PR updates Plugwise test fixtures and refactors config flow test coverage by renaming TEST_SMILE_ID to TEST_SMILE_HOST, expanding test coverage for abort and reconfigure flows, and clarifying documentation across CHANGELOG, docstrings, and test comments.

Changes

Plugwise Config Flow and Test Coverage Updates

Layer / File(s) Summary
Documentation and clarification updates
CHANGELOG.md, tests/components/plugwise/conftest.py, tests/components/plugwise/test_select.py, tests/components/plugwise/test_climate.py
CHANGELOG adds "Ongoing" section with PR #1084 reference and updates v0.64.4 with PR link; conftest.py fixture and test_select.py docstrings are shortened for clarity; test_climate.py inline comments are reworded to clarify HVAC mode transitions and schedule regulation behavior without changing test assertions.
Config flow constant rename and setup assertions
tests/components/plugwise/test_config_flow.py
TEST_SMILE_ID constant is renamed to TEST_SMILE_HOST; create-entry assertions in both user and ZeroConf flow paths are updated to validate unique_id against the renamed constant.
Config flow discovery update and abort test coverage
tests/components/plugwise/test_config_flow.py
test_zeroconf_discovery_update_configuration is refactored to use @pytest.mark.usefixtures and updated to use FlowResultType identity checks; new test_user_abort_existing_anna test covers user-flow abort when Anna already exists; expanded ZeroConf abort test suite validates abort reason values and flow handler progress for existing/duplicate device discovery scenarios.
Config flow reconfigure test refactoring
tests/components/plugwise/test_config_flow.py
Reconfigure tests are refactored to use mock_setup_entry fixture instead of explicit parameters; test_reconfigure_flow_other_smile is renamed to test_reconfigure_flow_smile_mismatch; new parameterized test_reconfigure_flow_connect_errors test covers connection error handling with recovery validation and CONF_HOST update assertions; existing port and options-flow tests are relocated to follow reconfigure suite.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

  • plugwise/plugwise-beta#989: Updates CHANGELOG.md with version-related entries similar to this PR's "Ongoing" section and PR references.
  • plugwise/plugwise-beta#750: Modifies config flow abort and conflict-detection logic that aligns with this PR's expanded abort test coverage for Anna vs. Adam device scenarios.

Suggested labels

downstreaming

Suggested reviewers

  • CoMPaTech
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch downstream-170760

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot requested a review from CoMPaTech June 6, 2026 11:33
@bouwew bouwew force-pushed the downstream-170760 branch from 5ffb344 to 5e177a9 Compare June 6, 2026 11:33
@sonarqubecloud

sonarqubecloud Bot commented Jun 6, 2026

Copy link
Copy Markdown

@bouwew bouwew marked this pull request as ready for review June 7, 2026 08:02
@bouwew bouwew requested a review from a team as a code owner June 7, 2026 08:02
@bouwew bouwew merged commit 698972a into main Jun 7, 2026
12 of 13 checks passed
@bouwew bouwew deleted the downstream-170760 branch June 7, 2026 08:03
@coderabbitai coderabbitai Bot added the downstreaming Things that are changed on HA-core side and to be applied to -beta label Jun 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

downstreaming Things that are changed on HA-core side and to be applied to -beta

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant