Next HA updates II#1082
Conversation
|
Complex PR? Review this PR in Change Stack to move by importance, not file order. Warning Review limit reached
More reviews will be available in 44 minutes and 28 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughModularizes service registration into a new services module, adds diagnostics entrypoint, updates the plugwise_command decorator, removes postponed annotation imports across modules, and updates changelog and services schema. ChangesPlugwise Integration Service Refactor and Feature Enhancements
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
coderabbitai
Bot
added
downstreaming
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@custom_components/plugwise/services.py`:
- Around line 49-50: The service schema in services.py now requires
CONF_CONFIG_ENTRY (the schema variable constructed with
vol.Required(CONF_CONFIG_ENTRY) in services.py), but the public service metadata
in custom_components/plugwise/services.yaml wasn’t updated; update services.yaml
to declare the new required "config_entry" argument (name and description, and
mark it required) so Home Assistant's service UI/docs match the actual schema
and callers see the required field.
- Around line 45-52: The service registration for plugwise.delete_notification
is incorrectly placed inside the handler function delete_notification so
async_setup_services never registers it; move the hass.services.async_register
call (using DOMAIN, SERVICE_DELETE, delete_notification, and schema with
CONF_CONFIG_ENTRY) out of the delete_notification function into the
async_setup_services setup path (or another module initialization function) so
the service is registered during integration setup rather than when the handler
is invoked.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: c1bb2fa2-bdbc-4f0d-aea5-f413b3deb5e7
📒 Files selected for processing (15)
CHANGELOG.mdcustom_components/plugwise/__init__.pycustom_components/plugwise/binary_sensor.pycustom_components/plugwise/button.pycustom_components/plugwise/climate.pycustom_components/plugwise/config_flow.pycustom_components/plugwise/const.pycustom_components/plugwise/diagnostics.pycustom_components/plugwise/entity.pycustom_components/plugwise/number.pycustom_components/plugwise/select.pycustom_components/plugwise/sensor.pycustom_components/plugwise/services.pycustom_components/plugwise/switch.pycustom_components/plugwise/util.py
💤 Files with no reviewable changes (10)
- custom_components/plugwise/button.py
- custom_components/plugwise/number.py
- custom_components/plugwise/switch.py
- custom_components/plugwise/diagnostics.py
- custom_components/plugwise/binary_sensor.py
- custom_components/plugwise/select.py
- custom_components/plugwise/climate.py
- custom_components/plugwise/entity.py
- custom_components/plugwise/sensor.py
- custom_components/plugwise/util.py
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@custom_components/plugwise/services.yaml`:
- Around line 3-8: The delete_notification service field in services.yaml is
named "config_entry" but the service schema and handler use ATTR_CONFIG_ENTRY_ID
("config_entry_id"); rename the field in
custom_components/plugwise/services.yaml from config_entry to config_entry_id
(and adjust any selector keys accordingly) so it matches the schema used in
services.py and the call.data lookup of ATTR_CONFIG_ENTRY_ID.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 14799739-38ba-4678-aaf5-678c643f4d8a
📒 Files selected for processing (2)
custom_components/plugwise/services.pycustom_components/plugwise/services.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
- custom_components/plugwise/services.py
|
2 participants
Changed required for compatibility with Core 2026.6.0.
Summary by CodeRabbit
New Features
Improvements
Code Quality