Skip to content

Commit 4664424

Browse files
authored
Merge pull request #1112 from pkgxdev/plus-probs
fix `pkgx +curl.se/ca-certs`
2 parents 1ae9d44 + 8a65614 commit 4664424

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

.github/workflows/ci.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,8 @@ jobs:
111111
- run: '! pkgx yarn --version'
112112
# coverage for display-name resolution
113113
- run: pkgx -v +agg
114+
# testing we correctly handle +pkg syntax for pkgs with no env
115+
- run: pkgx +curl.se/ca-certs
114116

115117
- name: generate coverage
116118
run: |

crates/cli/src/main.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ async fn main() -> Result<(), Box<dyn Error>> {
7171

7272
let mut pkgs = vec![];
7373

74-
for pkgspec in plus {
74+
for pkgspec in plus.clone() {
7575
let PackageReq {
7676
project: project_or_cmd,
7777
constraint,
@@ -238,7 +238,7 @@ async fn main() -> Result<(), Box<dyn Error>> {
238238
println!("{}", json);
239239
}
240240
Ok(())
241-
} else if !flags.version_n_continue {
241+
} else if !flags.version_n_continue && plus.is_empty() {
242242
clear_progress_bar();
243243
eprintln!("{}", help::usage());
244244
std::process::exit(2);

0 commit comments

Comments
 (0)