add conj support to records (implements IPersistentCollection)

Author: mpenet

pixie/stdlib.pxi

@@ -1293,6 +1293,22 @@ and implements IAssociative, ILookup and IObject."
                                (map #(map-entry % (get-field self# %))
                                     ~fields))
 
+                        'IPersistentCollection
+                        `(-conj [self# x]
+                                (cond
+                                  (instance? MapEntry x)
+                                  (assoc self# (key x) (val x))
+                                  (instance? PersistentVector x)
+                                  (if (= (count x) 2)
+                                    (assoc self# (first x) (second x))
+                                    (throw
+                                     [:pixie.stdlib/InvalidArgumentException
+                                      "Vector arg to record conj must be a pair"]))))
+
+                        `(-disj [self# x]
+                                (throw [:pixie.stdlib/NotImplementedException
+                                        "disj is not supported on defrecords"]))
+
                         'IMeta
                         `(-with-meta [self# ~meta-gs]
                                      (new ~nm

tests/pixie/tests/test-defrecord.pxi

@@ -14,7 +14,8 @@
            (t/assert= t t)
            (t/assert (satisfies? IRecord t))
            (t/assert (satisfies? IAssociative t))
-           (t/assert (satisfies? ILookup t))))
+           (t/assert (satisfies? ILookup t))
+           (t/assert (satisfies? IPersistentCollection t))))
 
 (t/deftest test-record-pred
   (t/assert (record? t1)))
@@ -54,6 +55,10 @@
            (t/assert (contains? t :two))
            (t/assert (contains? t :three))))
 
+(t/deftest test-ipersistentcoll
+  (t/assert= 11 (-> t1 (conj [:one 11]) :one))
+  (t/assert= 11 (-> t1 (conj (map-entry :one 11)) :one)))
+
 (t/deftest test-record-metadata
   (t/assert= nil (meta t1))
   (t/assert= :foo (-> t1 (with-meta :foo) meta)))