From 67f39efbb9e26b65ec02b450256b042ee97eb410 Mon Sep 17 00:00:00 2001 From: Teo Calin Date: Sun, 8 Nov 2026 12:52:55 -0800 Subject: [PATCH] ci(release): build, test and release the wallet with Go 1.27.3 Go 1.25 gets no more security fixes, and GO-2026-6809 (crypto/x509) is fixed only in 1.26.10 and 1.27.3. release.yml's test and build jobs use GO_VERSION (1.27.3), which also builds the signing-only pilotctl, and the build fails if the wallet binary reports any other toolchain. ci.yml tests on the same version. go.mod's go line is unchanged. --- .github/workflows/ci.yml | 3 ++- .github/workflows/release.yml | 11 +++++++++-- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 475c8c0..507bb5e 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -17,7 +17,8 @@ jobs: - uses: actions/setup-go@v7 with: - go-version: '1.25' + # The toolchain release.yml builds the shipped binaries with. + go-version: '1.27.3' cache: true - name: Run tests with coverage diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 181613f..0de6e4c 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -19,6 +19,11 @@ env: # handles the publisher private key, so it must not build whatever is on # pilotprotocol's main branch at release time. PILOTCTL_REF: v1.13.10 + # The Go toolchain the wallet binaries are built and tested with (it also + # builds the signing-only pilotctl above). Go 1.25 is end of life, and + # GO-2026-6809 in crypto/x509 is fixed only in 1.26.10 and 1.27.3. go.mod's + # go line is left alone; only the toolchain moves. + GO_VERSION: "1.27.3" jobs: test: @@ -29,7 +34,7 @@ jobs: ref: ${{ inputs.tag || github.ref }} - uses: actions/setup-go@v7 with: - go-version: '1.25' + go-version: ${{ env.GO_VERSION }} cache: true - run: go test -race -timeout 3m ./... @@ -67,7 +72,7 @@ jobs: ref: ${{ env.PILOTCTL_REF }} - uses: actions/setup-go@v7 with: - go-version: '1.25' + go-version: ${{ env.GO_VERSION }} cache: true - name: Resolve release version @@ -96,6 +101,8 @@ jobs: *) echo "::error::wrong executable format for $GOOS/$GOARCH: $FILE_OUTPUT"; exit 1 ;; esac test "$(stage/bin/wallet -version)" = "${{ steps.version.outputs.version }}" + go version stage/bin/wallet + go version stage/bin/wallet | grep -q ": go${GO_VERSION}\$" - name: Pin binary and sign manifest env: