Fix up tests

Author: iMattPro

tests/ext_test.php

@@ -12,7 +12,7 @@
 
 use PHPUnit\Framework\MockObject\MockObject;
 use phpbb\notification\manager;
-use phpbb\finder;
+use phpbb\finder\finder;
 use phpbb\db\migrator;
 use Symfony\Component\DependencyInjection\ContainerInterface;
 use phpbb\ideas\ext;
@@ -88,7 +88,7 @@ public function test_notification_steps(string $method, string $step): void
 		$this->assertEquals('notification', $state);
 	}
 
-	public function notification_step_provider(): array
+	public static function notification_step_provider(): array
 	{
 		return [
 			'enable step'  => ['enable_notifications', 'enable_step'],
@@ -127,7 +127,7 @@ private function setup_parent_step_expectations(string $step, $expected_result):
 		}
 	}
 
-	public function parent_step_provider(): array
+	public static function parent_step_provider(): array
 	{
 		return [
 			'enable parent step' => ['enable_step', false],

tests/functional/viewonline_test.php

@@ -60,7 +60,7 @@ public function test_viewonline_check_viewonline()
 				}
 				catch (\PHPUnit\Framework\AssertionFailedError $e)
 				{
-					$this->addWarning('Expected VIEWING_IDEAS lang string not found: ' . $e->getMessage());
+					$this->markTestIncomplete('Expected VIEWING_IDEAS lang string not found: ' . $e->getMessage());
 				}
 				return;
 			}

tests/ideas/idea_attributes_test.php

@@ -72,7 +72,7 @@ public function test_set_status($idea_id, $status)
 		self::assertEquals($status, $idea['idea_status']);
 	}
 
-	public function set_status_notification_data()
+	public static function set_status_notification_data()
 	{
 		return [
 			[1, 1, [], 'add_notifications'],