[WIP] parse dependencies recursively #606
Draft
micheleorselli wants to merge 6 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (58.21%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## add-parse-cache #606 +/- ##
=====================================================
- Coverage 98.29% 93.34% -4.95%
- Complexity 706 785 +79
=====================================================
Files 89 91 +2
Lines 2047 2238 +191
=====================================================
+ Hits 2012 2089 +77
- Misses 35 149 +114
🚀 New features to boost your workflow:
|
Replace the associative array in FilesToParse with an SplQueue + seen-set so that files added during parsing (resolved interfaces, traits, parent classes) are actually visited. The previous foreach-based iteration created an ArrayIterator snapshot at loop start, silently dropping all dynamically added files. Runner::collectParsedFiles now uses isEmpty()/shift() directly; the seen-set in FilesToParse persists across dequeues, making the redundant $parsedRealPaths guard in the consumer unnecessary. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.