Commit 7c44b7a
committed
Fix fseek() accepting $whence values that do not fit in an int
$whence is parsed as a zend_long but cast to a C int when handed to
php_stream_seek(). Values whose low 32 bits alias onto a valid seek
constant were accepted and acted upon: on a 64-bit build, SEEK_CUR +
2**32 seeks relative to the current position, SEEK_END + 2**32 relative
to the end, and PHP_INT_MIN relative to the start, each returning 0 for
success.
Reject values outside the int range before the cast and return -1,
which is already what fseek() returns for an invalid $whence that does
fit in an int. Platform constants such as SEEK_DATA and SEEK_HOLE fit in
an int and keep working.1 parent 65ae1ad commit 7c44b7a
3 files changed
Lines changed: 52 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
| 33 | + | |
| 34 | + | |
33 | 35 | | |
34 | 36 | | |
35 | 37 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1104 | 1104 | | |
1105 | 1105 | | |
1106 | 1106 | | |
| 1107 | + | |
| 1108 | + | |
| 1109 | + | |
| 1110 | + | |
1107 | 1111 | | |
1108 | 1112 | | |
1109 | 1113 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
0 commit comments