Skip to content

Commit 65741d3

Browse files
authored
fix ci (#91)
* fix ci * fix credo
1 parent b45f7e4 commit 65741d3

6 files changed

Lines changed: 27 additions & 27 deletions

File tree

.credo.exs

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -84,12 +84,12 @@
8484
#
8585
{Credo.Check.Design.AliasUsage,
8686
[priority: :low, if_nested_deeper_than: 2, if_called_more_often_than: 0]},
87+
{Credo.Check.Design.TagFIXME, []},
8788
# You can also customize the exit_status of each check.
8889
# If you don't want TODO comments to cause `mix credo` to fail, just
8990
# set this value to 0 (zero).
9091
#
9192
{Credo.Check.Design.TagTODO, [exit_status: 2]},
92-
{Credo.Check.Design.TagFIXME, []},
9393

9494
#
9595
## Readability Checks
@@ -122,19 +122,19 @@
122122
{Credo.Check.Refactor.Apply, []},
123123
{Credo.Check.Refactor.CondStatements, []},
124124
{Credo.Check.Refactor.CyclomaticComplexity, []},
125+
{Credo.Check.Refactor.FilterCount, []},
126+
{Credo.Check.Refactor.FilterFilter, []},
125127
{Credo.Check.Refactor.FunctionArity, []},
126128
{Credo.Check.Refactor.LongQuoteBlocks, []},
127-
{Credo.Check.Refactor.MatchInCondition, []},
128129
{Credo.Check.Refactor.MapJoin, []},
130+
{Credo.Check.Refactor.MatchInCondition, []},
129131
{Credo.Check.Refactor.NegatedConditionsInUnless, []},
130132
{Credo.Check.Refactor.NegatedConditionsWithElse, []},
131133
{Credo.Check.Refactor.Nesting, [max_nesting: 3]},
134+
{Credo.Check.Refactor.RedundantWithClauseResult, []},
135+
{Credo.Check.Refactor.RejectReject, []},
132136
{Credo.Check.Refactor.UnlessWithElse, []},
133137
{Credo.Check.Refactor.WithClauses, []},
134-
{Credo.Check.Refactor.FilterCount, []},
135-
{Credo.Check.Refactor.FilterFilter, []},
136-
{Credo.Check.Refactor.RejectReject, []},
137-
{Credo.Check.Refactor.RedundantWithClauseResult, []},
138138

139139
#
140140
## Warnings
@@ -150,7 +150,7 @@
150150
{Credo.Check.Warning.OperationWithConstantResult, []},
151151
{Credo.Check.Warning.RaiseInsideRescue, []},
152152
{Credo.Check.Warning.SpecWithStruct, []},
153-
{Credo.Check.Warning.WrongTestFileExtension, []},
153+
{Credo.Check.Warning.UnsafeExec, []},
154154
{Credo.Check.Warning.UnusedEnumOperation, []},
155155
{Credo.Check.Warning.UnusedFileOperation, []},
156156
{Credo.Check.Warning.UnusedKeywordOperation, []},
@@ -159,11 +159,12 @@
159159
{Credo.Check.Warning.UnusedRegexOperation, []},
160160
{Credo.Check.Warning.UnusedStringOperation, []},
161161
{Credo.Check.Warning.UnusedTupleOperation, []},
162-
{Credo.Check.Warning.UnsafeExec, []}
162+
{Credo.Check.Warning.WrongTestFileExtension, []}
163163
],
164164
disabled: [
165165
#
166-
# Checks scheduled for next check update (opt-in for now, just replace `false` with `[]`)
166+
# Checks scheduled for next check update (opt-in for now)
167+
{Credo.Check.Refactor.UtcNowTruncate, []},
167168

168169
#
169170
# Controversial and experimental checks (opt-in, just move the check to `:enabled`
@@ -179,13 +180,13 @@
179180
{Credo.Check.Readability.MultiAlias, []},
180181
{Credo.Check.Readability.NestedFunctionCalls, []},
181182
{Credo.Check.Readability.OneArityFunctionInPipe, []},
183+
{Credo.Check.Readability.OnePipePerLine, []},
182184
{Credo.Check.Readability.SeparateAliasRequire, []},
183185
{Credo.Check.Readability.SingleFunctionToBlockPipe, []},
184186
{Credo.Check.Readability.SinglePipe, []},
185187
{Credo.Check.Readability.Specs, []},
186188
{Credo.Check.Readability.StrictModuleLayout, []},
187189
{Credo.Check.Readability.WithCustomTaggedTuple, []},
188-
{Credo.Check.Readability.OnePipePerLine, []},
189190
{Credo.Check.Refactor.ABCSize, []},
190191
{Credo.Check.Refactor.AppendSingleItem, []},
191192
{Credo.Check.Refactor.DoubleBooleanNegation, []},

.github/workflows/ci.yml

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,11 @@ jobs:
1515
matrix:
1616
include:
1717
- pair:
18-
elixir: '1.15'
19-
otp: '25.3'
20-
lint: lint
18+
elixir: "1.16"
19+
otp: "26.1"
2120
- pair:
22-
elixir: '1.16'
23-
otp: '26.1'
21+
elixir: "1.18"
22+
otp: "27.2"
2423
lint: lint
2524

2625
runs-on: ubuntu-latest
@@ -33,7 +32,7 @@ jobs:
3332
otp-version: ${{matrix.pair.otp}}
3433
elixir-version: ${{matrix.pair.elixir}}
3534

36-
- uses: actions/cache@v2
35+
- uses: actions/cache@v4
3736
with:
3837
path: |
3938
deps

.tool-versions

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
elixir 1.15.7-otp-26
2-
erlang 26.1.2
1+
elixir 1.18.3-otp-27
2+
erlang 27.2.2

mix.exs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@ defmodule Parameter.MixProject do
3939
defp deps do
4040
[
4141
{:decimal, "~> 2.0", optional: true},
42-
{:dialyxir, "~> 1.4", only: [:dev, :test], runtime: false},
4342
{:credo, "~> 1.7", only: [:dev, :test], runtime: false},
43+
{:dialyxir, "~> 1.4", only: [:dev, :test], runtime: false},
4444
{:ex_doc, "~> 0.27", only: :dev, runtime: false},
4545
{:excoveralls, "~> 0.10", only: :test}
4646
]

mix.lock

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
%{
2-
"bunt": {:hex, :bunt, "0.2.1", "e2d4792f7bc0ced7583ab54922808919518d0e57ee162901a16a1b6664ef3b14", [:mix], [], "hexpm", "a330bfb4245239787b15005e66ae6845c9cd524a288f0d141c148b02603777a5"},
2+
"bunt": {:hex, :bunt, "1.0.0", "081c2c665f086849e6d57900292b3a161727ab40431219529f13c4ddcf3e7a44", [:mix], [], "hexpm", "dc5f86aa08a5f6fa6b8096f0735c4e76d54ae5c9fa2c143e5a1fc7c1cd9bb6b5"},
33
"certifi": {:hex, :certifi, "2.9.0", "6f2a475689dd47f19fb74334859d460a2dc4e3252a3324bd2111b8f0429e7e21", [:rebar3], [], "hexpm", "266da46bdb06d6c6d35fde799bcb28d36d985d424ad7c08b5bb48f5b5cdd4641"},
4-
"credo": {:hex, :credo, "1.7.1", "6e26bbcc9e22eefbff7e43188e69924e78818e2fe6282487d0703652bc20fd62", [:mix], [{:bunt, "~> 0.2.1", [hex: :bunt, repo: "hexpm", optional: false]}, {:file_system, "~> 0.2.8", [hex: :file_system, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "e9871c6095a4c0381c89b6aa98bc6260a8ba6addccf7f6a53da8849c748a58a2"},
5-
"decimal": {:hex, :decimal, "2.1.1", "5611dca5d4b2c3dd497dec8f68751f1f1a54755e8ed2a966c2633cf885973ad6", [:mix], [], "hexpm", "53cfe5f497ed0e7771ae1a475575603d77425099ba5faef9394932b35020ffcc"},
6-
"dialyxir": {:hex, :dialyxir, "1.4.3", "edd0124f358f0b9e95bfe53a9fcf806d615d8f838e2202a9f430d59566b6b53b", [:mix], [{:erlex, ">= 0.2.6", [hex: :erlex, repo: "hexpm", optional: false]}], "hexpm", "bf2cfb75cd5c5006bec30141b131663299c661a864ec7fbbc72dfa557487a986"},
4+
"credo": {:hex, :credo, "1.7.12", "9e3c20463de4b5f3f23721527fcaf16722ec815e70ff6c60b86412c695d426c1", [:mix], [{:bunt, "~> 0.2.1 or ~> 1.0", [hex: :bunt, repo: "hexpm", optional: false]}, {:file_system, "~> 0.2 or ~> 1.0", [hex: :file_system, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "8493d45c656c5427d9c729235b99d498bd133421f3e0a683e5c1b561471291e5"},
5+
"decimal": {:hex, :decimal, "2.3.0", "3ad6255aa77b4a3c4f818171b12d237500e63525c2fd056699967a3e7ea20f62", [:mix], [], "hexpm", "a4d66355cb29cb47c3cf30e71329e58361cfcb37c34235ef3bf1d7bf3773aeac"},
6+
"dialyxir": {:hex, :dialyxir, "1.4.5", "ca1571ac18e0f88d4ab245f0b60fa31ff1b12cbae2b11bd25d207f865e8ae78a", [:mix], [{:erlex, ">= 0.2.7", [hex: :erlex, repo: "hexpm", optional: false]}], "hexpm", "b0fb08bb8107c750db5c0b324fa2df5ceaa0f9307690ee3c1f6ba5b9eb5d35c3"},
77
"earmark_parser": {:hex, :earmark_parser, "1.4.42", "f23d856f41919f17cd06a493923a722d87a2d684f143a1e663c04a2b93100682", [:mix], [], "hexpm", "6915b6ca369b5f7346636a2f41c6a6d78b5af419d61a611079189233358b8b8b"},
8-
"erlex": {:hex, :erlex, "0.2.6", "c7987d15e899c7a2f34f5420d2a2ea0d659682c06ac607572df55a43753aa12e", [:mix], [], "hexpm", "2ed2e25711feb44d52b17d2780eabf998452f6efda104877a3881c2f8c0c0c75"},
8+
"erlex": {:hex, :erlex, "0.2.7", "810e8725f96ab74d17aac676e748627a07bc87eb950d2b83acd29dc047a30595", [:mix], [], "hexpm", "3ed95f79d1a844c3f6bf0cea61e0d5612a42ce56da9c03f01df538685365efb0"},
99
"ex_doc": {:hex, :ex_doc, "0.36.1", "4197d034f93e0b89ec79fac56e226107824adcce8d2dd0a26f5ed3a95efc36b1", [:mix], [{:earmark_parser, "~> 1.4.42", [hex: :earmark_parser, repo: "hexpm", optional: false]}, {:makeup_c, ">= 0.1.0", [hex: :makeup_c, repo: "hexpm", optional: true]}, {:makeup_elixir, "~> 0.14 or ~> 1.0", [hex: :makeup_elixir, repo: "hexpm", optional: false]}, {:makeup_erlang, "~> 0.1 or ~> 1.0", [hex: :makeup_erlang, repo: "hexpm", optional: false]}, {:makeup_html, ">= 0.1.0", [hex: :makeup_html, repo: "hexpm", optional: true]}], "hexpm", "d7d26a7cf965dacadcd48f9fa7b5953d7d0cfa3b44fa7a65514427da44eafd89"},
1010
"excoveralls": {:hex, :excoveralls, "0.18.3", "bca47a24d69a3179951f51f1db6d3ed63bca9017f476fe520eb78602d45f7756", [:mix], [{:castore, "~> 1.0", [hex: :castore, repo: "hexpm", optional: true]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "746f404fcd09d5029f1b211739afb8fb8575d775b21f6a3908e7ce3e640724c6"},
11-
"file_system": {:hex, :file_system, "0.2.10", "fb082005a9cd1711c05b5248710f8826b02d7d1784e7c3451f9c1231d4fc162d", [:mix], [], "hexpm", "41195edbfb562a593726eda3b3e8b103a309b733ad25f3d642ba49696bf715dc"},
11+
"file_system": {:hex, :file_system, "1.1.0", "08d232062284546c6c34426997dd7ef6ec9f8bbd090eb91780283c9016840e8f", [:mix], [], "hexpm", "bfcf81244f416871f2a2e15c1b515287faa5db9c6bcf290222206d120b3d43f6"},
1212
"hackney": {:hex, :hackney, "1.18.1", "f48bf88f521f2a229fc7bae88cf4f85adc9cd9bcf23b5dc8eb6a1788c662c4f6", [:rebar3], [{:certifi, "~> 2.9.0", [hex: :certifi, repo: "hexpm", optional: false]}, {:idna, "~> 6.1.0", [hex: :idna, repo: "hexpm", optional: false]}, {:metrics, "~> 1.0.0", [hex: :metrics, repo: "hexpm", optional: false]}, {:mimerl, "~> 1.1", [hex: :mimerl, repo: "hexpm", optional: false]}, {:parse_trans, "3.3.1", [hex: :parse_trans, repo: "hexpm", optional: false]}, {:ssl_verify_fun, "~> 1.1.0", [hex: :ssl_verify_fun, repo: "hexpm", optional: false]}, {:unicode_util_compat, "~> 0.7.0", [hex: :unicode_util_compat, repo: "hexpm", optional: false]}], "hexpm", "a4ecdaff44297e9b5894ae499e9a070ea1888c84afdd1fd9b7b2bc384950128e"},
1313
"idna": {:hex, :idna, "6.1.1", "8a63070e9f7d0c62eb9d9fcb360a7de382448200fbbd1b106cc96d3d8099df8d", [:rebar3], [{:unicode_util_compat, "~> 0.7.0", [hex: :unicode_util_compat, repo: "hexpm", optional: false]}], "hexpm", "92376eb7894412ed19ac475e4a86f7b413c1b9fbb5bd16dccd57934157944cea"},
1414
"jason": {:hex, :jason, "1.4.4", "b9226785a9aa77b6857ca22832cffa5d5011a667207eb2a0ad56adb5db443b8a", [:mix], [{:decimal, "~> 1.0 or ~> 2.0", [hex: :decimal, repo: "hexpm", optional: true]}], "hexpm", "c5eb0cab91f094599f94d55bc63409236a8ec69a21a67814529e8d5f6cc90b3b"},

test/parameter_test.exs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ defmodule ParameterTest do
164164
field :email, :string, validator: &Validators.email/1
165165
field :age, :integer, validator: {&Validators.length/2, min: 18, max: 72}
166166
field :code, :string, validator: {&Validators.regex/2, regex: ~r/code/}
167-
field :user_code, :string, validator: {&__MODULE__.is_equal/2, to: "0000"}
167+
field :user_code, :string, validator: {&__MODULE__.equal?/2, to: "0000"}
168168

169169
field :status, __MODULE__.Status,
170170
required: true,
@@ -180,7 +180,7 @@ defmodule ParameterTest do
180180
end
181181
end
182182

183-
def is_equal(value, to: to_value) do
183+
def equal?(value, to: to_value) do
184184
if value == to_value do
185185
:ok
186186
else

0 commit comments

Comments
 (0)