Skip to content

Commit 488f129

Browse files
devvaannshabose
authored andcommitted
fix: always show problems panel option in the quick access as it shows proper context
1 parent 2511dcc commit 488f129

1 file changed

Lines changed: 5 additions & 22 deletions

File tree

src/view/DefaultPanelView.js

Lines changed: 5 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -119,31 +119,21 @@ define(function (require, exports, module) {
119119
}
120120

121121
/**
122-
* Check whether there are currently lint errors/warnings.
123-
* The status bar indicator gets the "inspection-errors" class when problems exist.
124-
* @return {boolean}
125-
* @private
126-
*/
127-
function _hasProblems() {
128-
const $indicator = $("#status-inspection");
129-
return $indicator.length > 0 && $indicator.hasClass("inspection-errors");
130-
}
131-
132-
/**
133-
* Show or hide the Git and Problems buttons based on current state.
122+
* Show or hide buttons based on current state.
123+
* The Problems button is always shown since the panel now displays
124+
* meaningful content regardless of error state.
134125
* @private
135126
*/
136127
function _updateButtonVisibility() {
137128
if (!_$panel) {
138129
return;
139130
}
140131
_$panel.find('.default-panel-btn[data-btn-id="git"]').toggle(_isGitAvailable());
141-
_$panel.find('.default-panel-btn[data-btn-id="problems"]').toggle(_hasProblems());
142132
}
143133

144134
/**
145-
* Set up MutationObservers on the Git toolbar icon and status-inspection
146-
* indicator so that button visibility updates live.
135+
* Set up MutationObservers on the Git toolbar icon so that
136+
* button visibility updates live.
147137
* @private
148138
*/
149139
function _observeStateChanges() {
@@ -153,13 +143,6 @@ define(function (require, exports, module) {
153143
const gitObserver = new MutationObserver(_updateButtonVisibility);
154144
gitObserver.observe(gitIcon, {attributes: true, attributeFilter: ["class"]});
155145
}
156-
157-
// Watch status-inspection indicator for class changes (inspection-errors)
158-
const statusInspection = document.getElementById("status-inspection");
159-
if (statusInspection) {
160-
const inspectionObserver = new MutationObserver(_updateButtonVisibility);
161-
inspectionObserver.observe(statusInspection, {attributes: true, attributeFilter: ["class"]});
162-
}
163146
}
164147

165148
/**

0 commit comments

Comments
 (0)