Skip to content

Commit 245427c

Browse files
committed
test: extend control-bar test plan with design-mode auto-exit cases
Adds a new section 11b to control-bar-tests-todo.md tracking the auto-exit behavior wired into the tools panel (app-drawer-button), Find in Files, Quick Open, and the git toolbar icon — plus future follow-ups for each (floating variants that would avoid the need to exit design mode).
1 parent 9c60f6b commit 245427c

1 file changed

Lines changed: 29 additions & 0 deletions

File tree

test/control-bar-tests-todo.md

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,35 @@ Keep this file updated as we add coverage; remove lines as suites land.
148148
- [ ] Toggle back to normal mode preserves live preview (panel stays open
149149
at `savedToolbarWidth` or the default).
150150

151+
## 11b. Auto-exit design mode from conflicting surfaces
152+
153+
Each of these invocations must exit design mode before running its
154+
own behavior. Verify `WorkspaceManager.isInDesignMode()` is `true`
155+
pre-action, then `false` post-action, and that the feature's UI
156+
renders on the normal editor chrome (not a blank / broken region).
157+
158+
- [ ] Clicking `#app-drawer-button` while in design mode exits design
159+
mode, then toggles the default (tools) bottom panel.
160+
- [ ] Running `Commands.CMD_FIND_IN_FILES` while in design mode exits
161+
design mode before the find bar / results panel mount.
162+
- [ ] Running `Commands.NAVIGATE_QUICK_OPEN` while in design mode
163+
exits design mode before Quick Open's modal bar is shown.
164+
- [ ] Clicking `#git-toolbar-icon` while in design mode exits design
165+
mode, then `Panel.toggle()` opens/closes the git panel.
166+
- [ ] In the above four cases, when NOT in design mode the auto-exit
167+
branch is skipped and the original behavior runs unchanged.
168+
169+
Future follow-ups (no tests yet — track as TODOs alongside the site
170+
comments added in the source files):
171+
172+
- [ ] Tools panel floats over live preview so users can peek without
173+
leaving design mode.
174+
- [ ] Find in Files renders an overlay modal bar and a floating
175+
results surface compatible with design mode.
176+
- [ ] Quick Open gets a spotlight-style floating picker usable in
177+
design mode.
178+
- [ ] Git panel gains a floating variant for design mode.
179+
151180
## 12. Integration with NoDistractions
152181

153182
- [ ] Design mode + toggling `noDistractions` preference to `true`:

0 commit comments

Comments
 (0)