fix: copy problem button not working when clicking on the icon

Author: abose

src/language/CodeInspection.js

@@ -512,9 +512,9 @@ define(function (require, exports, module) {
         const $lineElement = $problemsPanelTable.find('td.line-number[data-line="' + lineNumber + '"]');
         if ($lineElement.length) {
             $lineElement[0].scrollIntoView({ behavior: 'instant', block: 'start' });
-            return true;
+            return $($lineElement[0]).parent();
         }
-        return false;
+        return null;
     }
 
 
@@ -1136,7 +1136,10 @@ define(function (require, exports, module) {
             .on("click", "tr", function (e) {
                 if ($(e.target).hasClass('ph-copy-problem')) {
                     // Retrieve the message from the data attribute of the clicked element
-                    const message = $(e.target).parent().parent().find(".line-text").text();
+                    let message = $(e.target).parent().parent().find(".line-text").text();
+                    if(!message){
+                        message = $(e.target).parent().parent().parent().find(".line-text").text();
+                    }
                     message && Phoenix.app.copyToClipboard(message);
                     e.preventDefault();
                     e.stopPropagation();

test/spec/CodeInspection-integ-test.js

@@ -115,6 +115,8 @@ define(function (require, exports, module) {
             }
         }
 
+        let savedCopyFn;
+
         beforeAll(async function () {
             testWindow = await SpecRunnerUtils.createTestWindowAndRun({forceReload: true});
             // Load module instances from brackets.test
@@ -127,20 +129,22 @@ define(function (require, exports, module) {
             CodeInspection = brackets.test.CodeInspection;
             PreferencesManager = brackets.test.PreferencesManager;
             CodeInspection.toggleEnabled(true);
-
             await SpecRunnerUtils.loadProjectInTestWindow(testFolder);
+            savedCopyFn = testWindow.Phoenix.app.copyToClipboard;
         }, 30000);
 
         beforeEach(function () {
             // this is to make the tests run faster
             prefs.set(CodeInspection._PREF_ASYNC_TIMEOUT, 500);
+            testWindow.Phoenix.app.copyToClipboard = savedCopyFn;
         });
 
         afterEach(function () {
             testWindow.closeAllFiles();
         });
 
         afterAll(async function () {
+            testWindow.Phoenix.app.copyToClipboard = savedCopyFn;
             testWindow    = null;
             $             = null;
             brackets      = null;
@@ -1079,6 +1083,25 @@ define(function (require, exports, module) {
                 expect(fixPos(EditorManager.getActiveEditor().getCursorPos())).toEqual(fixPos({line: 1, ch: 3}));
             });
 
+            it("should be able to copy problem message", async function () {
+                const codeInspector = createCodeInspector("javascript linter", failLintResult());
+                CodeInspection.register("javascript", codeInspector);
+
+                await awaitsForDone(SpecRunnerUtils.openProjectFiles(["errors.js"]), "open test file");
+
+                const $problemLine = CodeInspection.scrollToProblem(1);
+                let copiedVal;
+                testWindow.Phoenix.app.copyToClipboard = function (val) {
+                    copiedVal = val;
+                };
+                const $copyBtnElems = $problemLine.find(".ph-copy-problem");
+                for(let i=0; i<$copyBtnElems.length; i++) {
+                    copiedVal = null;
+                    $copyBtnElems[i].click();
+                    expect(copiedVal).toBe("Some errors here and there");
+                }
+            });
+
             it("should Go to First Error with errors from two providers", async function () {
                 var codeInspector1 = createCodeInspector("javascript linter 1", {
                     errors: [