chore: package.json validation in zip

Author: abose

src/api/publishGithubRelease.js

@@ -151,13 +151,30 @@ function _validateGitHubReleaseAssets(githubReleaseDetails, issueMessages) {
 async function _downloadAndValidateExtensionZip(githubReleaseTag, extensionZipAsset, issueMessages) {
     const targetPath = `${EXTENSION_DOWNLOAD_DIR}/${githubReleaseTag.owner}_${githubReleaseTag.repo}_${githubReleaseTag.tag}_${extensionZipAsset.name}`;
     await downloader.downloadFile(extensionZipAsset.browser_download_url, targetPath);
-    const {packageJSON, error} = await ZipUtils.getExtensionPackageJSON(targetPath);
+    let {packageJSON, error} = await ZipUtils.getExtensionPackageJSON(targetPath);
     if(error) {
         issueMessages.push(error);
         throw {status: HTTP_STATUS_CODES.BAD_REQUEST,
             updatePublishErrors: true,
             error};
     }
+    let requiredParams = ["name", "title", "description", "homepage", "version", "author", "license"];
+    let missingParams = [];
+    for(let param of requiredParams){
+        if(!packageJSON[param]){
+            missingParams.push(param);
+        }
+    }
+    if(!packageJSON?.engines?.brackets){
+        missingParams.push(`"engines":{"brackets":<version Eg. ">=0.34.0"}>`);
+    }
+    if(missingParams.length){
+        error = "Required parameters missing in package.json: " + missingParams;
+        issueMessages.push(error);
+        throw {status: HTTP_STATUS_CODES.BAD_REQUEST,
+            updatePublishErrors: true,
+            error};
+    }
     return targetPath;
 }
 

test/unit/data/packagejson.js

@@ -18,3 +18,47 @@ export const VALID_PACKAGE_JSON = {
         "brackets": ">=0.34.0"
     }
 };
+
+export const REGISTRY_PACKAGE_JSON = {
+    "metadata": {
+        "name": "angular.moduler",
+        "title": "Angular Module generator",
+        "description": "Generate an angular module. Conforms with Angular Style Guide of John Papa",
+        "homepage": "https://github.com/louiealmeda/brackets-angular-moduler",
+        "version": "0.0.1",
+        "author": {
+            "name": "Louie Almeda"
+        },
+        "license": "MIT",
+        "categories": "",
+        "keywords": [
+            "angular", "module", "generate"
+        ],
+        "files": [
+            "main.js",
+            "README.md"
+        ],
+        "engines": {
+            "brackets": ">=0.34.0"
+        }
+    },
+    "owner": "github:louiealmeda",
+    "versions": [
+        {
+            "version": "0.0.1",
+            "published": "2016-10-06T05:48:09.634Z",
+            "brackets": ">=0.34.0",
+            "downloads": 9189
+        }
+    ],
+    "totalDownloads": 9189,
+    "recent": {
+        "20180905": 2,
+        "20180906": 5,
+        "20180907": 5,
+        "20180908": 5,
+        "20180909": 103,
+        "20180910": 85,
+        "20180911": 10
+    }
+};