Improved type comments [skip ci]

Author: ankane

pgvector/halfvec.py

@@ -76,7 +76,7 @@ def _to_db(cls, value: object) -> str | None:
             return value
 
         if not isinstance(value, cls):
-            value = cls(value)  # ty: ignore[invalid-argument-type]
+            value = cls(value)  # type: ignore
 
         return value.to_text()
 
@@ -86,7 +86,7 @@ def _to_db_binary(cls, value: object) -> bytes | None:
             return value
 
         if not isinstance(value, cls):
-            value = cls(value)  # ty: ignore[invalid-argument-type]
+            value = cls(value)  # type: ignore
 
         return value.to_binary()
 

pgvector/vector.py

@@ -76,7 +76,7 @@ def _to_db(cls, value: object) -> str | None:
             return value
 
         if not isinstance(value, cls):
-            value = cls(value)  # ty: ignore[invalid-argument-type]
+            value = cls(value)  # type: ignore
 
         return value.to_text()
 
@@ -86,7 +86,7 @@ def _to_db_binary(cls, value: object) -> bytes | None:
             return value
 
         if not isinstance(value, cls):
-            value = cls(value)  # ty: ignore[invalid-argument-type]
+            value = cls(value)  # type: ignore
 
         return value.to_binary()
 

tests/test_bit.py

@@ -15,17 +15,17 @@ def test_list(self):
 
     def test_list_none(self):
         with pytest.raises(ValueError) as error:
-            Bit([True, None, True])  # ty: ignore[invalid-argument-type]
+            Bit([True, None, True])  # type: ignore
         assert str(error.value) == 'expected list[bool]'
 
     def test_list_int(self):
         with pytest.raises(ValueError) as error:
-            Bit([254, 7, 0])  # ty: ignore[invalid-argument-type]
+            Bit([254, 7, 0])  # type: ignore
         assert str(error.value) == 'expected list[bool]'
 
     def test_list_list(self):
         with pytest.raises(ValueError) as error:
-            Bit([[True, False], [True, False]])  # ty: ignore[invalid-argument-type]
+            Bit([[True, False], [True, False]])  # type: ignore
         assert str(error.value) == 'expected list[bool]'
 
     def test_str(self):
@@ -67,7 +67,7 @@ def test_ndarray_uint16(self):
 
     def test_bool(self):
         with pytest.raises(ValueError) as error:
-            Bit(True)  # ty: ignore[invalid-argument-type]
+            Bit(True)  # type: ignore
         assert str(error.value) == 'expected bytes, str, list, or ndarray'
 
     def test_random(self):

tests/test_half_vector.py

@@ -18,12 +18,12 @@ def test_list_empty(self):
 
     def test_list_str(self):
         with pytest.raises(ValueError) as error:
-            HalfVector([1, 'two', 3])  # ty: ignore[invalid-argument-type]
+            HalfVector([1, 'two', 3])  # type: ignore
         assert str(error.value) == 'expected list[float]'
 
     def test_list_list(self):
         with pytest.raises(ValueError) as error:
-            HalfVector([[1, 2], [3, 4]])  # ty: ignore[invalid-argument-type]
+            HalfVector([[1, 2], [3, 4]])  # type: ignore
         assert str(error.value) == 'expected list[float]'
 
     @pytest.mark.skipif(not NUMPY_AVAILABLE, reason='NumPy required')
@@ -34,7 +34,7 @@ def test_ndarray(self):
 
     def test_int(self):
         with pytest.raises(ValueError) as error:
-            HalfVector(1)  # ty: ignore[invalid-argument-type]
+            HalfVector(1)  # type: ignore
         assert str(error.value) == 'expected list or ndarray'
 
     def test_repr(self):

tests/test_sparse_vector.py

@@ -28,7 +28,7 @@ def test_list_empty(self):
 
     def test_list_dimensions(self):
         with pytest.raises(ValueError) as error:
-            SparseVector([1, 0, 2, 0, 3, 0], 6)  # ty: ignore[invalid-argument-type]
+            SparseVector([1, 0, 2, 0, 3, 0], 6)  # type: ignore
         assert str(error.value) == 'extra argument'
 
     @pytest.mark.skipif(not NUMPY_AVAILABLE, reason='NumPy required')
@@ -60,7 +60,7 @@ def test_coo_array(self):
     @pytest.mark.skipif(not SCIPY_AVAILABLE, reason='SciPy required')
     def test_coo_array_dimensions(self):
         with pytest.raises(ValueError) as error:
-            SparseVector(coo_array(np.array([1, 0, 2, 0, 3, 0])), 6)  # ty: ignore[invalid-argument-type]
+            SparseVector(coo_array(np.array([1, 0, 2, 0, 3, 0])), 6)  # type: ignore
         assert str(error.value) == 'extra argument'
 
     @pytest.mark.skipif(not SCIPY_AVAILABLE, reason='SciPy required')

tests/test_vector.py

@@ -18,12 +18,12 @@ def test_list_empty(self):
 
     def test_list_str(self):
         with pytest.raises(ValueError) as error:
-            Vector([1, 'two', 3])  # ty: ignore[invalid-argument-type]
+            Vector([1, 'two', 3])  # type: ignore
         assert str(error.value) == 'expected list[float]'
 
     def test_list_list(self):
         with pytest.raises(ValueError) as error:
-            Vector([[1, 2], [3, 4]])  # ty: ignore[invalid-argument-type]
+            Vector([[1, 2], [3, 4]])  # type: ignore
         assert str(error.value) == 'expected list[float]'
 
     @pytest.mark.skipif(not NUMPY_AVAILABLE, reason='NumPy required')
@@ -34,7 +34,7 @@ def test_ndarray(self):
 
     def test_int(self):
         with pytest.raises(ValueError) as error:
-            Vector(1)  # ty: ignore[invalid-argument-type]
+            Vector(1)  # type: ignore
         assert str(error.value) == 'expected list or ndarray'
 
     def test_repr(self):