Merge pull request #3063 from sakirr05/fix/cppcoreguidelines-explicit-virtual-functions-3045

clang-tidy: fix explicit virtual functions in remaining headers

Author: cvvergara

.clang-tidy

@@ -11,7 +11,6 @@ Checks: >
     -cppcoreguidelines-avoid-const-or-ref-data-members,
     -cppcoreguidelines-avoid-do-while,
     -cppcoreguidelines-avoid-magic-numbers,
-    -cppcoreguidelines-explicit-virtual-functions,
     -cppcoreguidelines-macro-usage,
     -cppcoreguidelines-narrowing-conversions,
     -cppcoreguidelines-no-malloc,

include/bdAstar/bdAstar.hpp

@@ -78,7 +78,7 @@ class Pgr_bdAstar : public Pgr_bidirectional<G> {
         m_log << "pgr_bdAstar constructor\n";
     }
 
-    virtual ~Pgr_bdAstar() = default;
+    ~Pgr_bdAstar() override = default;
 
     Path pgr_bdAstar(V start_vertex, V end_vertex,
             int heuristic,
@@ -98,7 +98,7 @@ class Pgr_bdAstar : public Pgr_bidirectional<G> {
     using Pgr_bidirectional<G>::clean_log;
 
  private:
-    void explore_forward(const Cost_Vertex_pair &node) {
+    void explore_forward(const Cost_Vertex_pair &node) override {
         typename G::EO_i out, out_end;
 
         auto current_node = node.second;
@@ -124,7 +124,7 @@ class Pgr_bdAstar : public Pgr_bidirectional<G> {
         forward_finished[current_node] = true;
     }
 
-    void explore_backward(const Cost_Vertex_pair &node) {
+    void explore_backward(const Cost_Vertex_pair &node) override {
         typename G::EI_i in, in_end;
 
         auto current_cost = node.first;

include/bdDijkstra/bdDijkstra.hpp

@@ -80,7 +80,7 @@ class Pgr_bdDijkstra : public Pgr_bidirectional<G> {
              m_log << "pgr_bdDijkstra constructor\n";
          }
 
-     virtual ~Pgr_bdDijkstra() = default;
+     ~Pgr_bdDijkstra() override = default;
 
      Path pgr_bdDijkstra(V start_vertex, V end_vertex, bool only_cost) {
          m_log << "pgr_bdDijkstra\n";
@@ -96,7 +96,7 @@ class Pgr_bdDijkstra : public Pgr_bidirectional<G> {
 
 
  private:
-     void explore_forward(const Cost_Vertex_pair &node) {
+     void explore_forward(const Cost_Vertex_pair &node) override {
          typename G::EO_i out, out_end;
 
          auto current_cost = node.first;
@@ -119,7 +119,7 @@ class Pgr_bdDijkstra : public Pgr_bidirectional<G> {
          forward_finished[current_node] = true;
      }
 
-     void explore_backward(const Cost_Vertex_pair &node) {
+     void explore_backward(const Cost_Vertex_pair &node) override {
          typename G::EI_i in, in_end;
 
          auto current_cost = node.first;

include/spanningTree/kruskal.hpp

@@ -42,7 +42,7 @@ namespace functions {
 template <class G>
 class Pgr_kruskal : public Pgr_mst<G> {
  public:
-     virtual ~Pgr_kruskal() = default;
+     ~Pgr_kruskal() override = default;
      std::vector<MST_rt> kruskal(G &graph);
 
      std::vector<MST_rt> kruskalBFS(
@@ -66,7 +66,7 @@ class Pgr_kruskal : public Pgr_mst<G> {
      typedef typename G::E E;
 
      /* Does all the work */
-     void generate_mst(const G &graph);
+     void generate_mst(const G &graph) override;
 };
 
 

include/spanningTree/prim.hpp

@@ -51,7 +51,7 @@ class Pgr_prim : public Pgr_mst<G> {
      typedef typename G::B_G B_G;
 
  public:
-     virtual ~Pgr_prim() = default;
+     ~Pgr_prim() override = default;
      std::vector<MST_rt> prim(G &graph);
 
      std::vector<MST_rt> primBFS(
@@ -82,7 +82,7 @@ class Pgr_prim : public Pgr_mst<G> {
              const G &graph,
              int64_t root_vertex);
 
-     void generate_mst(const G &graph);
+     void generate_mst(const G &graph) override;
 
  private:
      // Member

include/yen/turnRestrictedPath.hpp

@@ -66,7 +66,7 @@ class Pgr_turnRestrictedPath : public Pgr_ksp< G > {
              m_restrictions(restrictions) {
              }
 
-         void on_insert_first_solution(const Path path) const {
+         void on_insert_first_solution(const Path path) const override {
              if (path.empty()) return;
              if (has_restriction(path)) return;
 
@@ -75,7 +75,7 @@ class Pgr_turnRestrictedPath : public Pgr_ksp< G > {
              if (m_stop_on_first) throw found_goals();
          }
 
-         void on_insert_to_heap(const Path path) const {
+         void on_insert_to_heap(const Path path) const override {
              if (path.empty()) return;
              if (has_restriction(path)) return;