Added more unit tests on hash signing.

Author: Ross Nicoll

bitcoin/core/key.py

@@ -99,7 +99,6 @@ def get_ecdh_key(self, other_pubkey, kdf=lambda k: hashlib.sha256(k).digest()):
         return kdf(r)
 
     def sign(self, hash):
-        # FIXME: need unit tests for below cases
         if not isinstance(hash, bytes):
             raise TypeError('Hash must be bytes instance; got %r' % hash.__class__)
         if len(hash) != 32:

bitcoin/tests/test_wallet.py

@@ -218,7 +218,19 @@ def test_sign(self):
         hash = b'\x00' * 32
         sig = key.sign(hash)
 
-        # FIXME: need better tests than this
+        # Check a valid signature
         self.assertTrue(key.pub.verify(hash, sig))
+
+        # Check invalid hash returns false
         self.assertFalse(key.pub.verify(b'\xFF'*32, sig))
+        # Check invalid signature returns false
         self.assertFalse(key.pub.verify(hash, sig[0:-1] + b'\x00'))
+
+    def test_sign_invalid_hash(self):
+        key = CBitcoinSecret('5KJvsngHeMpm884wtkJNzQGaCErckhHJBGFsvd3VyK5qMZXj3hS')
+        with self.assertRaises(TypeError):
+          sig = key.sign('0' * 32)
+
+        hash = b'\x00' * 32
+        with self.assertRaises(ValueError):
+          sig = key.sign(hash[0:-2])