Change TokenGenerator::generateIdToken() to make the $dpopKey parameter required.

Author: Potherca

src/TokenGenerator.php

@@ -44,7 +44,7 @@ public function generateRegistrationAccessToken($clientId, $privateKey) {
 		return $token->toString();
 	}
 
-	public function generateIdToken($accessToken, $clientId, $subject, $nonce, $privateKey, $dpopKey=null) {
+	public function generateIdToken($accessToken, $clientId, $subject, $nonce, $privateKey, $dpopKey) {
 		$issuer = $this->config->getServer()->get(OidcMeta::ISSUER);
 
 		$jwks = $this->getJwks();

tests/unit/TokenGeneratorTest.php

@@ -254,6 +254,26 @@ final public function testIdTokenGenerationWithoutPrivateKey(): void
         );
     }
 
+    /**
+     * @testdox Token Generator SHOULD complain WHEN asked to generate a IdToken without dpopKey
+     *
+     * @covers ::generateIdToken
+     */
+    final public function testIdTokenGenerationWithoutDpopKey(): void
+    {
+        $tokenGenerator = $this->createTokenGenerator();
+
+        $this->expectArgumentCountError(6);
+
+        $tokenGenerator->generateIdToken(
+            'mock access token',
+            'mock clientId',
+            'mock subject',
+            'mock nonce',
+            'mock private key'
+        );
+    }
+
     /**
      * @testdox Token Generator SHOULD return a IdToken WHEN asked to generate a IdToken with clientId and privateKey
      *