Merge pull request #24 from pdsinterop/feature/phpunit-workflow

Feature/phpunit workflow

Author: ylebre

.github/workflows/tests.yml

@@ -0,0 +1,32 @@
+---
+name: Test jobs
+
+on:
+  - push
+  - pull_request
+  # Allow manually triggering the workflow.
+  - workflow_dispatch
+
+# Cancels all previous workflow runs for the same branch that have not yet completed.
+concurrency:
+  # The concurrency group contains the workflow name and the branch name.
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  phpunit:
+    runs-on: ubuntu-20.04
+
+    strategy:
+      matrix:
+        php: ['8.0', '8.1']
+
+    steps:
+      - uses: actions/checkout@v3
+      - uses: shivammathur/setup-php@v2
+        with:
+          php-version: ${{ matrix.php }}
+      - uses: "ramsey/composer-install@v2"
+        with:
+          composer-options: --no-scripts
+      - run: bin/phpunit

composer.json

@@ -32,7 +32,7 @@
   "require-dev": {
     "ext-xdebug": "*",
     "ext-xml": "*",
-    "phpunit/phpunit": "^8.5 | ^9.5"
+    "phpunit/phpunit": "^9"
   },
   "scripts": {
     "tests:example": "php -S localhost:8080 -t ./tests/ ./tests/example.php",

phpunit.xml.dist

@@ -0,0 +1,33 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<phpunit
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:noNamespaceSchemaLocation="./vendor/phpunit/phpunit/phpunit.xsd"
+
+    beStrictAboutCoversAnnotation="true"
+    beStrictAboutOutputDuringTests="true"
+    beStrictAboutTodoAnnotatedTests="true"
+    bootstrap="vendor/autoload.php"
+    cacheResultFile=".phpunit.cache/test-results"
+    convertDeprecationsToExceptions="true"
+    failOnRisky="true"
+    failOnWarning="true"
+    forceCoversAnnotation="true"
+    verbose="true"
+>
+    <testsuites>
+        <testsuite name="all">
+          <directory suffix=".php">tests/</directory>
+        </testsuite>
+    </testsuites>
+
+    <coverage processUncoveredFiles="false">
+        <include>
+            <directory suffix=".php">src/</directory>
+        </include>
+        <report>
+            <!-- clover outputFile="build/clover.xml"/ -->
+            <!-- html outputDirectory="build/coverage"/ -->
+            <text outputFile="php://stdout"/>
+        </report>
+    </coverage>
+</phpunit>

tests/dummyTest.php

@@ -0,0 +1,20 @@
+<?php
+/*
+    This file is here as an example and to make sure the github actions runner has a test to run.
+    It does not actually test anything.
+*/
+    
+namespace Pdsinterop\Dummy;
+
+use PHPUnit\Framework\TestCase;
+
+class DummyTest extends TestCase
+{
+    /**
+     * @coversNothing
+     */
+    public function testDummy(): void
+    {
+        $this->assertTrue(true);
+    }
+}

tests/example.php

@@ -7,6 +7,9 @@
 use Pdsinterop\Solid\Auth\Exception\LogicException;
 use PHPUnit\Framework\TestCase;
 
+/**
+ * @coversNothing
+ */
 class ServerTest extends TestCase
 {
     final public function testServerConfigShouldComplainWhenInstantiatedWithoutData() : void
@@ -95,13 +98,25 @@ final public function testServerConfigShouldReturnArrayWhenSerializedWithRequire
      */
     final public function testServerConfigShouldReturnExpectedValuesWhenSerializedWithRequiredKeysPresent(array $actual)
     {
-        self::assertEquals($actual,  [
+        self::assertEquals([
             'authorization_endpoint' => 'https://server/authorize',
             'id_token_signing_alg_values_supported' => ['RS256'],
             'issuer' => 'https://server/identifier',
             'jwks_uri' => 'https://server/jwk',
-            'response_types_supported' => ['code', 'id_token', 'token'],
+            'response_types_supported' => ['code', 'code token', 'code id_token', 'id_token code', 'id_token', 'id_token token', 'code id_token token', 'none'],
             'subject_types_supported' => ['public'],
-        ]);
+            'token_types_supported' => ['legacyPop','dpop'],
+            'response_modes_supported' => ['query', 'fragment'],
+            'grant_types_supported' => ['authorization_code', 'implicit', 'refresh_token', 'client_credentials'],
+            'token_endpoint_auth_methods_supported' => 'client_secret_basic',
+            'token_endpoint_auth_signing_alg_values_supported' => ['RS256'],
+            'display_values_supported' => [],
+            'claim_types_supported' => ['normal'],
+            'claims_supported' => [],
+            'claims_parameter_supported' => false,
+            'request_parameter_supported' => true,
+            'request_uri_parameter_supported' => false,
+            'require_request_uri_registration' => false
+        ], $actual);
     }
 }

tests/unit/Config/ServerTest.php

@@ -84,6 +84,6 @@ final public function testEnumValuesShouldMatchExpectedValues(array $actual) : v
     {
         $expected = $this->getExpectedValues();
 
-        self::assertEquals($actual, $expected);
+        self::assertEquals($expected, $actual);
     }
 }

tests/unit/Enum/AbstractEnumTest.php

@@ -4,6 +4,9 @@
 
 use Pdsinterop\Solid\Auth\Enum\AbstractEnumTest as TestCase;
 
+/**
+ * @coversNothing
+ */
 class OpenIdConnectMetadataTest extends TestCase
 {
     final public function getEnum() : OpenIdConnectMetadata
@@ -49,6 +52,9 @@ final public function getExpectedValues() : array
             'userinfo_encryption_enc_values_supported',
             'userinfo_endpoint',
             'userinfo_signing_alg_values_supported',
+            'token_types_supported',
+            'check_session_iframe',
+            'end_session_endpoint'
         ];
     }