Fix bug in RepositoryFactory caused by incorrect checks.

Potherca · Potherca · commit 5849a16c3a68 · 2020-09-12T15:01:02.000+02:00
diff --git a/src/Factory/RepositoryFactory.php b/src/Factory/RepositoryFactory.php
@@ -35,7 +35,7 @@ final public function createAuthCodeRepository() : AuthCodeRepositoryInterface
     {
         static $clientEntity;
 
-        if ($this->repositories[Repository::AUTH_CODE] === null) {
+        if (array_key_exists(Repository::AUTH_CODE, $this->repositories) === false) {
             $clientEntity = $this->createClientRepository()->createClientEntity();
         }
 
@@ -61,7 +61,7 @@ final public function createScopeRepository() : ScopeRepositoryInterface
 
     private function createOnce(string $className, array $properties = []): RepositoryInterface
     {
-        if ($this->repositories[$className] === null) {
+        if (array_key_exists($className, $this->repositories) === false) {
             $this->repositories[$className] = $this->create($className, $properties);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ final public function createAuthCodeRepository() : AuthCodeRepositoryInterface`
`35`	`35`	`{`
`36`	`36`	`static $clientEntity;`
`37`	`37`
`38`		`- if ($this->repositories[Repository::AUTH_CODE] === null) {`
	`38`	`+ if (array_key_exists(Repository::AUTH_CODE, $this->repositories) === false) {`
`39`	`39`	`$clientEntity = $this->createClientRepository()->createClientEntity();`
`40`	`40`	`}`
`41`	`41`
`@@ -61,7 +61,7 @@ final public function createScopeRepository() : ScopeRepositoryInterface`
`61`	`61`
`62`	`62`	`private function createOnce(string $className, array $properties = []): RepositoryInterface`
`63`	`63`	`{`
`64`		`- if ($this->repositories[$className] === null) {`
	`64`	`+ if (array_key_exists($className, $this->repositories) === false) {`
`65`	`65`	`$this->repositories[$className] = $this->create($className, $properties);`
`66`	`66`	`}`
`67`	`67`