From 27a6875319181cc36b7e37e3c47037ed2fcf8d79 Mon Sep 17 00:00:00 2001 From: Benny Powers Date: Wed, 15 Apr 2026 15:03:45 +0300 Subject: [PATCH 1/2] fix(table): fix accessibility audit failures - Correct ARIA role for column headers (`colheader` -> `columnheader`) - Add accessible label to the row expand/collapse toggle button - Add `aria-controls` linking the toggle button to its expansion content Closes #2813 Assisted-By: Claude Opus 4.6 (1M context) --- .changeset/fix-table-accessibility.md | 8 ++++++++ elements/pf-table/context.ts | 2 +- elements/pf-table/pf-th.ts | 2 +- elements/pf-table/pf-thead.ts | 2 +- elements/pf-table/pf-tr.ts | 2 ++ 5 files changed, 13 insertions(+), 3 deletions(-) create mode 100644 .changeset/fix-table-accessibility.md diff --git a/.changeset/fix-table-accessibility.md b/.changeset/fix-table-accessibility.md new file mode 100644 index 0000000000..85d6db4e9d --- /dev/null +++ b/.changeset/fix-table-accessibility.md @@ -0,0 +1,8 @@ +--- +"@patternfly/elements": patch +--- +``: fix accessibility audit failures + +- Fix column header ARIA role (`colheader` -> `columnheader`) +- Add accessible label to the row expand/collapse toggle button +- Add `aria-controls` linking the toggle button to its expansion content diff --git a/elements/pf-table/context.ts b/elements/pf-table/context.ts index d128980e17..4db36698b5 100644 --- a/elements/pf-table/context.ts +++ b/elements/pf-table/context.ts @@ -2,4 +2,4 @@ import { createContextWithRoot } from '@patternfly/pfe-core/functions/context.js export const thRoleContext: { __context__: unknown; -} = createContextWithRoot<'rowheader' | 'colheader'>('pf-th-role'); +} = createContextWithRoot<'rowheader' | 'columnheader'>('pf-th-role'); diff --git a/elements/pf-table/pf-th.ts b/elements/pf-table/pf-th.ts index 9effd562bf..e1bb7c6a8d 100644 --- a/elements/pf-table/pf-th.ts +++ b/elements/pf-table/pf-th.ts @@ -51,7 +51,7 @@ export class PfTh extends LitElement { @property() key!: string; @consume({ context: thRoleContext }) - private contextualRole: 'colheader' | 'rowheader' = 'rowheader'; + private contextualRole: 'columnheader' | 'rowheader' = 'rowheader'; override connectedCallback(): void { super.connectedCallback(); diff --git a/elements/pf-table/pf-thead.ts b/elements/pf-table/pf-thead.ts index c46a51ccb4..755224f182 100644 --- a/elements/pf-table/pf-thead.ts +++ b/elements/pf-table/pf-thead.ts @@ -14,7 +14,7 @@ import { provide } from '@lit/context'; export class PfThead extends LitElement { static readonly styles: CSSStyleSheet[] = [styles]; - @provide({ context: thRoleContext }) private thRowContext = 'colheader'; + @provide({ context: thRoleContext }) private thRowContext = 'columnheader'; connectedCallback(): void { super.connectedCallback(); diff --git a/elements/pf-table/pf-tr.ts b/elements/pf-table/pf-tr.ts index 9193dba0ae..a2687bcd69 100644 --- a/elements/pf-table/pf-tr.ts +++ b/elements/pf-table/pf-tr.ts @@ -109,7 +109,9 @@ export class PfTr extends LitElement { Date: Wed, 15 Apr 2026 15:22:03 +0300 Subject: [PATCH 2/2] docs: changeset Fix accessibility features for the pf-table component, including column header role and accessible label for the row toggle button. --- .changeset/fix-table-accessibility.md | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/.changeset/fix-table-accessibility.md b/.changeset/fix-table-accessibility.md index 85d6db4e9d..f34671ef71 100644 --- a/.changeset/fix-table-accessibility.md +++ b/.changeset/fix-table-accessibility.md @@ -1,8 +1,4 @@ --- "@patternfly/elements": patch --- -``: fix accessibility audit failures - -- Fix column header ARIA role (`colheader` -> `columnheader`) -- Add accessible label to the row expand/collapse toggle button -- Add `aria-controls` linking the toggle button to its expansion content +``: fix accessibility features: column header role, accessible label for row toggle button, etc.