Commit cc071a6
authored
Fix rollbar projects frames #43
This PR fixes how the stacktrace is presented to the rollbar service and thus the ui. If we keep the SetServerRoot line all the frames are marked as non-project frame. Once we get rid of the line rollbar correctly shows us the stack frame as if it belongs to the project. I suspect this has to do with projects using pkg (and pkg itself when running examplelog) being built in with go modules enabled.
examplelog is also updated to be more inline with the "proper" way to use log:
- defer the `Close` right after checking error returned by `Init`
- Use the correct package name when calling `Package`2 files changed
Lines changed: 2 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| 22 | + | |
22 | 23 | | |
23 | | - | |
| 24 | + | |
24 | 25 | | |
25 | 26 | | |
26 | 27 | | |
| |||
31 | 32 | | |
32 | 33 | | |
33 | 34 | | |
34 | | - | |
35 | 35 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
32 | 31 | | |
33 | 32 | | |
34 | 33 | | |
| |||
0 commit comments