Merge pull request #129 from packethost/test-error-handling

add tests for BaseAPI non-json error handling

Author: Chris Privitere

packet/baseapi.py

@@ -8,7 +8,7 @@
 from packet import __version__
 
 
-class Error(Exception):  # pragma: no cover
+class Error(Exception):
     """Base exception class for this module"""
 
     def __init__(self, msg, cause=None):
@@ -96,7 +96,7 @@ def call_api(self, method, type="GET", params=None):  # noqa
                 resp = requests.delete(url, headers=headers)
             elif type == "PATCH":
                 resp = requests.patch(url, headers=headers, data=json.dumps(params))
-            else:  # pragma: no cover
+            else:
                 raise Error(
                     "method type not recognized as one of GET, POST, DELETE or PATCH: %s"
                     % type

test/test_baseapi.py

@@ -20,6 +20,37 @@ def test_cause(self):
         self.assertIn(error.cause, cause)
 
 
+class BaseAPITest(unittest.TestCase):
+    def setUp(self):
+        self.auth_token = "fake_auth_token"
+        self.consumer_token = "fake_consumer_token"
+        self.end_point = "api.packet.net"
+        self._user_agent_prefix = "fake_user_agent"
+
+    def test_init_all(self):
+        base = packet.baseapi.BaseAPI(
+            self.auth_token, self.consumer_token, self._user_agent_prefix
+        )
+        self.assertEqual(base.end_point, self.end_point)
+        self.assertEqual(base.auth_token, self.auth_token)
+        self.assertEqual(base.consumer_token, self.consumer_token)
+        self.assertEqual(base._user_agent_prefix, self._user_agent_prefix)
+
+    def test_call_api_with_end_point(self):
+        base = packet.baseapi.BaseAPI(
+            self.auth_token, self.consumer_token, self._user_agent_prefix
+        )
+
+        if int(sys.version[0]) == 3:
+            self.assertRaisesRegex(
+                packet.Error,
+                "method type not recognized as one of",
+                base.call_api,
+                "fake_path",
+                "bad_method",
+            )
+
+
 class ResponseErrorTest(unittest.TestCase):
     def setUp(self):
         self.resp500 = obj({"status_code": 500})
@@ -31,6 +62,10 @@ def test_init_empty(self):
         error = packet.ResponseError(self.resp500, None, None)
         self.assertIn("empty", str(error))
 
+    def test_init_string(self):
+        error = packet.ResponseError(self.resp500, "whoops", None)
+        self.assertIn("whoops", str(error))
+
     def test_init_error(self):
         error = packet.ResponseError(self.resp500, self.errBoom, self.exception)
         self.assertIn("Error 500: boom", str(error))