test: use requests_mock to enable call_api logic tests

Author: mmlb

packet/Manager.py

@@ -16,7 +16,7 @@ def __init__(self, auth_token, consumer_token=None):
         super(Manager, self).__init__(auth_token, consumer_token)
 
     def call_api(self, method, type='GET', params=None):
-        return super(Manager, self).call_api(method, type, params)  # pragma: no cover
+        return super(Manager, self).call_api(method, type, params)
 
     def get_user(self):
         return self.call_api("user")

packet/baseapi.py

@@ -32,7 +32,7 @@ def __init__(self, auth_token, consumer_token):
         self.end_point = 'api.packet.net'
         self._log = logging.getLogger(__name__)
 
-    def call_api(self, method, type='GET', params=None):  # pragma: no cover
+    def call_api(self, method, type='GET', params=None):  # noqa
         if params is None:
             params = {}
 
@@ -57,22 +57,22 @@ def call_api(self, method, type='GET', params=None):  # pragma: no cover
                 resp = requests.delete(url, headers=headers)
             elif type == 'PATCH':
                 resp = requests.patch(url, headers=headers, data=json.dumps(params))
-            else:
+            else:  # pragma: no cover
                 raise Error('method type not recognized as one of GET, POST, DELETE or PATCH: %s' % type)
-        except requests.exceptions.RequestException as e:
+        except requests.exceptions.RequestException as e:  # pragma: no cover
             raise Error('Communcations error: %s' % str(e), e)
 
         if not resp.content:
             data = None
         elif resp.headers.get("content-type", "").startswith("application/json"):
             try:
                 data = resp.json()
-            except ValueError as e:
+            except ValueError as e:  # pragma: no cover
                 raise JSONReadError('Read failed: %s' % e.message, e)
         else:
-            data = resp.content
+            data = resp.content  # pragma: no cover
 
-        if not resp.ok:
+        if not resp.ok:  # pragma: no cover
             msg = data
             if not data:
                 msg = "(empty response)"
@@ -82,7 +82,7 @@ def call_api(self, method, type='GET', params=None):  # pragma: no cover
 
         try:
             resp.raise_for_status()
-        except requests.HTTPError as e:
+        except requests.HTTPError as e:  # pragma: no cover
             raise Error('Error {0}: {1}'.format(resp.status_code, resp.reason), e)
 
         self.meta = None
@@ -94,7 +94,7 @@ def call_api(self, method, type='GET', params=None):  # pragma: no cover
 
         return data
 
-    def _parse_params(self, params):  # pragma: no cover
+    def _parse_params(self, params):
         vals = list()
         for k, v in params.items():
             vals.append(str("%s=%s" % (k, v)))

test/test_packet.py

@@ -1,7 +1,9 @@
 import sys
 import json
 import unittest
+
 import packet
+import requests_mock
 
 
 class PacketManagerTest(unittest.TestCase):
@@ -201,12 +203,30 @@ def test_validate_capacity(self):
 class PacketMockManager(packet.Manager):
 
     def call_api(self, method, type='GET', params=None):
-        if type == 'DELETE':
-            return None
-        else:
+        with requests_mock.Mocker() as m:
+            mock = {
+                'DELETE': m.delete,
+                'GET': m.get,
+                'PUT': m.put,
+                'POST': m.post,
+                'PATCH': m.patch,
+            }[type]
+
+            if type == 'DELETE':
+                mock(requests_mock.ANY)
+                return super(PacketMockManager, self).call_api(method, type, params)
+
             fixture = '%s_%s' % (type.lower(), method.lower())
-            with open('test/fixtures/%s.json' % (fixture.replace('/', '_').split("?")[0])) as data_file:
-                return json.load(data_file)
+            fixture = fixture.replace('/', '_').split('?')[0]
+            fixture = 'test/fixtures/%s.json' % fixture
+
+            headers = {'content-type': 'application/json'}
+
+            with open(fixture) as data_file:
+                j = json.load(data_file)
+
+            mock(requests_mock.ANY, headers=headers, json=j)
+            return super(PacketMockManager, self).call_api(method, type, params)
 
 
 if __name__ == '__main__':