Do not leave a dangling link to local variable in member variable

joto · joto · commit e22eb13fb0c5 · 2024-12-17T14:49:35.000+01:00
diff --git a/include/osmium/io/detail/xml_input_format.hpp b/include/osmium/io/detail/xml_input_format.hpp
@@ -776,6 +776,9 @@ namespace osmium {
 
                     mark_header_as_done();
                     flush_final_buffer();
+
+                    // so we don't have a dangling link to local parser variable
+                    m_expat_xml_parser = nullptr;
                 }
 
             }; // class XMLParser

Original file line number	Diff line number	Diff line change
`@@ -776,6 +776,9 @@ namespace osmium {`
`776`	`776`
`777`	`777`	`mark_header_as_done();`
`778`	`778`	`flush_final_buffer();`
	`779`	`+`
	`780`	`+ // so we don't have a dangling link to local parser variable`
	`781`	`+ m_expat_xml_parser = nullptr;`
`779`	`782`	`}`
`780`	`783`
`781`	`784`	`}; // class XMLParser`