Various clang-tidy fixes

Author: joto

.clang-tidy

@@ -1,5 +1,5 @@
 ---
-Checks: '*,-abseil-string-find-str-contains,-altera-*,-android-cloexec-*,-bugprone-branch-clone,-bugprone-macro-parentheses,-cert-dcl21-cpp,-cert-err58-cpp,-clang-analyzer-optin.cplusplus.VirtualCall,-cppcoreguidelines-avoid-c-arrays,-cppcoreguidelines-avoid-magic-numbers,-cppcoreguidelines-macro-usage,-cppcoreguidelines-non-private-member-variables-in-classes,-cppcoreguidelines-owning-memory,-cppcoreguidelines-pro-bounds-array-to-pointer-decay,-cppcoreguidelines-pro-bounds-constant-array-index,-cppcoreguidelines-pro-bounds-pointer-arithmetic,-cppcoreguidelines-pro-type-const-cast,-cppcoreguidelines-pro-type-reinterpret-cast,-cppcoreguidelines-pro-type-static-cast-downcast,-cppcoreguidelines-pro-type-vararg,-fuchsia-*,-google-runtime-references,-hicpp-avoid-c-arrays,-hicpp-invalid-access-moved,-hicpp-no-array-decay,-hicpp-no-assembler,-hicpp-vararg,-llvmlibc-*,-llvm-qualified-auto,-misc-macro-parentheses,-misc-non-private-member-variables-in-classes,-misc-no-recursion,-misc-unused-parameters,-modernize-avoid-c-arrays,-modernize-make-unique,-modernize-raw-string-literal,-modernize-use-trailing-return-type,-readability-avoid-const-params-in-decls,-readability-implicit-bool-cast,-readability-implicit-bool-conversion,-readability-magic-numbers,-readability-qualified-auto'
+Checks: '*,-abseil-string-find-str-contains,-altera-*,-android-cloexec-*,-bugprone-branch-clone,-bugprone-easily-swappable-parameters,-bugprone-macro-parentheses,-cert-dcl21-cpp,-cert-err58-cpp,-clang-analyzer-optin.cplusplus.VirtualCall,-cppcoreguidelines-avoid-c-arrays,-cppcoreguidelines-avoid-magic-numbers,-cppcoreguidelines-macro-usage,-cppcoreguidelines-non-private-member-variables-in-classes,-cppcoreguidelines-owning-memory,-cppcoreguidelines-pro-bounds-array-to-pointer-decay,-cppcoreguidelines-pro-bounds-constant-array-index,-cppcoreguidelines-pro-bounds-pointer-arithmetic,-cppcoreguidelines-pro-type-const-cast,-cppcoreguidelines-pro-type-reinterpret-cast,-cppcoreguidelines-pro-type-static-cast-downcast,-cppcoreguidelines-pro-type-vararg,-fuchsia-*,-google-runtime-references,-hicpp-avoid-c-arrays,-hicpp-invalid-access-moved,-hicpp-no-array-decay,-hicpp-no-assembler,-hicpp-vararg,-llvmlibc-*,-llvm-qualified-auto,-misc-macro-parentheses,-misc-non-private-member-variables-in-classes,-misc-no-recursion,-misc-unused-parameters,-modernize-avoid-c-arrays,-modernize-make-unique,-modernize-raw-string-literal,-modernize-use-trailing-return-type,-readability-avoid-const-params-in-decls,-readability-function-cognitive-complexity,-readability-identifier-length,-readability-implicit-bool-cast,-readability-implicit-bool-conversion,-readability-magic-numbers,-readability-qualified-auto'
 #
 #  For a list of check options, see:
 #  https://clang.llvm.org/extra/clang-tidy/checks/list.html
@@ -19,6 +19,9 @@ Checks: '*,-abseil-string-find-str-contains,-altera-*,-android-cloexec-*,-bugpro
 #    Nice idea but collides but with switch statements we'll need to use
 #    fall-throughs to fix this, which is also bad.
 #
+#  bugprone-easily-swappable-parameters
+#    Interesting test, but not something we can do much about in many places.
+#
 #  bugprone-macro-parentheses
 #    False positive in the only place where it reports something and
 #    disabling locally doesn't work.
@@ -137,6 +140,9 @@ Checks: '*,-abseil-string-find-str-contains,-altera-*,-android-cloexec-*,-bugpro
 #  readability-function-cognitive-complexity
 #    Sometimes the large functions are needed.
 #
+#  readability-identifier-length
+#    Too strict.
+#
 #  readability-implicit-bool-cast
 #    Old name for readability-implicit-bool-conversion.
 #

include/osmium/io/detail/xml_input_format.hpp

@@ -171,7 +171,7 @@ namespace osmium {
                 class ExpatXMLParser {
 
                     XML_Parser m_parser;
-                    std::exception_ptr m_exception_ptr{};
+                    std::exception_ptr m_exception_ptr{}; // NOLINT(bugprone-throw-keyword-missing) see https://bugs.llvm.org/show_bug.cgi?id=52400
 
                     template <typename TFunc>
                     void member_wrap(XMLParser& xml_parser, TFunc&& func) noexcept {

include/osmium/io/reader.hpp

@@ -211,7 +211,7 @@ namespace osmium {
                         }
                     }
                     if (dup2(pipefd[1], 1) < 0) { // put end of pipe as stdout/stdin
-                        exit(1);
+                        std::exit(1); // NOLINT(concurrency-mt-unsafe)
                     }
 
                     ::open("/dev/null", O_RDONLY); // stdin
@@ -221,7 +221,7 @@ namespace osmium {
                     // in theory this execute() function could be used for other commands, but it is
                     // only used for curl at the moment, so this is okay.
                     if (::execlp(command.c_str(), command.c_str(), "-g", filename.c_str(), nullptr) < 0) {
-                        exit(1);
+                        std::exit(1); // NOLINT(concurrency-mt-unsafe)
                     }
                 }
                 // parent

include/osmium/io/reader_iterator.hpp

@@ -45,7 +45,7 @@ namespace osmium {
         }
 
         inline InputIterator<Reader> end(Reader& /*reader*/) {
-            return InputIterator<Reader>();
+            return {};
         }
 
     } // namespace io

include/osmium/memory/buffer.hpp

@@ -161,9 +161,7 @@ namespace osmium {
              * Most methods of the Buffer class will not work with an invalid
              * buffer.
              */
-            Buffer() noexcept :
-                m_next_buffer() {
-            }
+            Buffer() noexcept = default;
 
             /**
              * Constructs a valid externally memory-managed buffer using the
@@ -176,7 +174,6 @@ namespace osmium {
              *         the alignment.
              */
             explicit Buffer(unsigned char* data, std::size_t size) :
-                m_next_buffer(),
                 m_data(data),
                 m_capacity(size),
                 m_written(size),
@@ -199,7 +196,6 @@ namespace osmium {
              *         than capacity.
              */
             explicit Buffer(unsigned char* data, std::size_t capacity, std::size_t committed) :
-                m_next_buffer(),
                 m_data(data),
                 m_capacity(capacity),
                 m_written(committed),
@@ -229,7 +225,6 @@ namespace osmium {
              *         than capacity.
              */
             explicit Buffer(std::unique_ptr<unsigned char[]> data, std::size_t capacity, std::size_t committed) :
-                m_next_buffer(),
                 m_memory(std::move(data)),
                 m_data(m_memory.get()),
                 m_capacity(capacity),
@@ -259,7 +254,6 @@ namespace osmium {
              *        becomes to small?
              */
             explicit Buffer(std::size_t capacity, auto_grow auto_grow = auto_grow::yes) :
-                m_next_buffer(),
                 m_memory(new unsigned char[calculate_capacity(capacity)]),
                 m_data(m_memory.get()),
                 m_capacity(calculate_capacity(capacity)),