clang-tidy links for parentheses

Author: joto

include/osmium/area/detail/basic_assembler.hpp

@@ -326,7 +326,7 @@ namespace osmium {
                             const int64_t ay = a.y();
                             const int64_t by = b.y();
                             const int64_t ly = end_location.y();
-                            const auto z = (bx - ax) * (ly - ay) - (by - ay) * (lx - ax);
+                            const auto z = ((bx - ax) * (ly - ay)) - ((by - ay) * (lx - ax));
                             if (debug()) {
                                 std::cerr << "      Segment z=" << z << '\n';
                             }
@@ -353,7 +353,7 @@ namespace osmium {
                             const int64_t ay = a.y();
                             const int64_t by = b.y();
                             const int64_t ly = location.y();
-                            const auto z = (bx - ax) * (ly - ay) - (by - ay) * (lx - ax);
+                            const auto z = ((bx - ax) * (ly - ay)) - ((by - ay) * (lx - ax));
 
                             if (z >= 0) {
                                 nesting += segment->is_reverse() ? -1 : 1;
@@ -362,7 +362,7 @@ namespace osmium {
                                 }
                                 if (segment->ring()->is_outer()) {
                                     const double y = static_cast<double>(ay) +
-                                                     static_cast<double>((by - ay) * (lx - ax)) / static_cast<double>(bx - ax);
+                                                     (static_cast<double>((by - ay) * (lx - ax)) / static_cast<double>(bx - ax));
                                     if (debug()) {
                                         std::cerr << "        Segment belongs to outer ring (y=" << y << " ring=" << *segment->ring() << ")\n";
                                     }

include/osmium/area/detail/node_ref_segment.hpp

@@ -319,11 +319,11 @@ namespace osmium {
 
                     // intersection in a point
 
-                    const int64_t na = (q1.x - q0.x) * (p0.y - q0.y) -
-                                       (q1.y - q0.y) * (p0.x - q0.x);
+                    const int64_t na = ((q1.x - q0.x) * (p0.y - q0.y)) -
+                                       ((q1.y - q0.y) * (p0.x - q0.x));
 
-                    const int64_t nb = (p1.x - p0.x) * (p0.y - q0.y) -
-                                       (p1.y - p0.y) * (p0.x - q0.x);
+                    const int64_t nb = ((p1.x - p0.x) * (p0.y - q0.y)) -
+                                       ((p1.y - p0.y) * (p0.x - q0.x));
 
                     if ((d > 0 && na >= 0 && na <= d && nb >= 0 && nb <= d) ||
                         (d < 0 && na <= 0 && na >= d && nb <= 0 && nb >= d)) {

include/osmium/geom/haversine.hpp

@@ -69,7 +69,7 @@ namespace osmium {
                 double lath = std::sin(deg_to_rad(c1.y - c2.y) * 0.5);
                 lath *= lath;
                 const double tmp = std::cos(deg_to_rad(c1.y)) * std::cos(deg_to_rad(c2.y));
-                return 2.0 * EARTH_RADIUS_IN_METERS * std::asin(std::sqrt(lath + tmp * lonh));
+                return 2.0 * EARTH_RADIUS_IN_METERS * std::asin(std::sqrt(lath + (tmp * lonh)));
             }
 
             /**

include/osmium/geom/mercator_projection.hpp

@@ -54,7 +54,7 @@ namespace osmium {
             }
 
             inline double lat_to_y_with_tan(double lat) { // not constexpr because math functions aren't
-                return earth_radius_for_epsg3857 * std::log(std::tan(osmium::geom::PI / 4 + deg_to_rad(lat) / 2));
+                return earth_radius_for_epsg3857 * std::log(std::tan((osmium::geom::PI / 4) + (deg_to_rad(lat) / 2)));
             }
 
 #ifdef OSMIUM_USE_SLOW_MERCATOR_PROJECTION
@@ -101,7 +101,7 @@ namespace osmium {
             }
 
             inline double y_to_lat(double y) { // not constexpr because math functions aren't
-                return rad_to_deg(2 * std::atan(std::exp(y / earth_radius_for_epsg3857)) - osmium::geom::PI / 2);
+                return rad_to_deg((2 * std::atan(std::exp(y / earth_radius_for_epsg3857))) - (osmium::geom::PI / 2));
             }
 
         } // namespace detail

include/osmium/index/map/flex_mem.hpp

@@ -192,8 +192,8 @@ namespace osmium {
 
                 std::size_t used_memory() const noexcept final {
                     return sizeof(FlexMem) +
-                           m_sparse_entries.size() * sizeof(entry) +
-                           m_dense_blocks.size() * (block_size * sizeof(TValue) + sizeof(std::vector<TValue>));
+                           (m_sparse_entries.size() * sizeof(entry)) +
+                           (m_dense_blocks.size() * (block_size * sizeof(TValue) + sizeof(std::vector<TValue>)));
                 }
 
                 void set(const TId id, const TValue value) final {

include/osmium/index/map/sparse_mem_map.hpp

@@ -63,7 +63,7 @@ namespace osmium {
                 // and parent plus some overhead for color of red-black-tree
                 // or similar).
                 enum {
-                    element_size = sizeof(TId) + sizeof(TValue) + sizeof(void*) * 4U
+                    element_size = sizeof(TId) + sizeof(TValue) + (sizeof(void*) * 4U)
                 };
 
                 std::map<TId, TValue> m_elements;

include/osmium/index/multimap/sparse_mem_multimap.hpp

@@ -60,7 +60,7 @@ namespace osmium {
                 // and parent plus some overhead for color of red-black-tree
                 // or similar).
                 enum {
-                    element_size = sizeof(TId) + sizeof(TValue) + sizeof(void*) * 4U
+                    element_size = sizeof(TId) + sizeof(TValue) + (sizeof(void*) * 4U)
                 };
 
             public:

include/osmium/relations/members_database.hpp

@@ -185,7 +185,7 @@ namespace osmium {
              * in the stash. Used for debugging.
              */
             std::size_t used_memory() const noexcept {
-                return sizeof(element) * m_elements.capacity() +
+                return (sizeof(element) * m_elements.capacity()) +
                        sizeof(MembersDatabaseCommon);
             }
 

include/osmium/relations/relations_database.hpp

@@ -142,7 +142,7 @@ namespace osmium {
              * Complexity: Constant.
              */
             std::size_t used_memory() const noexcept {
-                return sizeof(element) * m_elements.capacity() +
+                return (sizeof(element) * m_elements.capacity()) +
                        sizeof(RelationsDatabase);
             }
 

include/osmium/storage/item_stash.hpp

@@ -208,7 +208,7 @@ namespace osmium {
         std::size_t used_memory() const noexcept {
             return sizeof(ItemStash) +
                    m_buffer.capacity() +
-                   m_index.capacity() * sizeof(std::size_t);
+                   (m_index.capacity() * sizeof(std::size_t));
         }
 
         /**