Various cleanups based on clang-tidy warnings

Author: joto

include/osmium/index/map.hpp

@@ -236,6 +236,7 @@ namespace osmium {
 
             std::vector<std::string> map_types() const {
                 std::vector<std::string> result;
+                result.reserve(m_callbacks.size());
 
                 for (const auto& cb : m_callbacks) {
                     result.push_back(cb.first);

include/osmium/io/bzip2_compression.hpp

@@ -112,7 +112,7 @@ namespace osmium {
 #ifdef _MSC_VER
                     osmium::detail::disable_invalid_parameter_handler diph;
 #endif
-                    m_file = fdopen(fd, mode);
+                    m_file = fdopen(fd, mode); // NOLINT(cppcoreguidelines-prefer-member-initializer)
                     if (!m_file) {
 
                         // Do not close stdout
@@ -134,7 +134,7 @@ namespace osmium {
                     osmium::detail::disable_invalid_parameter_handler diph;
 #endif
                     if (m_file) {
-                        fclose(m_file);
+                        (void)fclose(m_file);
                     }
                 }
 

include/osmium/io/gzip_compression.hpp

@@ -116,7 +116,7 @@ namespace osmium {
 #ifdef _MSC_VER
                 osmium::detail::disable_invalid_parameter_handler diph;
 #endif
-                m_gzfile = ::gzdopen(osmium::io::detail::reliable_dup(fd), "wb");
+                m_gzfile = ::gzdopen(osmium::io::detail::reliable_dup(fd), "wb"); // NOLINT(cppcoreguidelines-prefer-member-initializer)
                 if (!m_gzfile) {
                     throw gzip_error{"gzip error: write initialization failed"};
                 }
@@ -192,7 +192,7 @@ namespace osmium {
 #ifdef _MSC_VER
                 osmium::detail::disable_invalid_parameter_handler diph;
 #endif
-                m_gzfile = ::gzdopen(fd, "rb");
+                m_gzfile = ::gzdopen(fd, "rb"); // NOLINT(cppcoreguidelines-prefer-member-initializer)
                 if (!m_gzfile) {
                     try {
                         osmium::io::detail::reliable_close(fd);