open_for_writing will not return 1, because 1 is stdout

joto · joto · commit 3739d6b60868 · 2025-01-09T11:09:53.000+01:00
diff --git a/test/t/io/test_bzip2.cpp b/test/t/io/test_bzip2.cpp
@@ -139,7 +139,7 @@ TEST_CASE("Write bzip2-compressed file with implicit close") {
 
     const std::string output_file = "test_gzip_out.txt.bz2";
     const int fd = osmium::io::detail::open_for_writing(output_file, osmium::io::overwrite::allow);
-    REQUIRE(fd > 0);
+    REQUIRE(fd > 1);
 
     {
         osmium::io::Bzip2Compressor comp{fd, osmium::io::fsync::yes};

Original file line number	Diff line number	Diff line change
`@@ -139,7 +139,7 @@ TEST_CASE("Write bzip2-compressed file with implicit close") {`
`139`	`139`
`140`	`140`	`const std::string output_file = "test_gzip_out.txt.bz2";`
`141`	`141`	`const int fd = osmium::io::detail::open_for_writing(output_file, osmium::io::overwrite::allow);`
`142`		`- REQUIRE(fd > 0);`
	`142`	`+ REQUIRE(fd > 1);`
`143`	`143`
`144`	`144`	`{`
`145`	`145`	`osmium::io::Bzip2Compressor comp{fd, osmium::io::fsync::yes};`