Add missing virtual destructors and use rule of 5

For classes derived from virtual base classes.

Author: joto

examples/osmium_index_lookup.cpp

@@ -70,7 +70,7 @@ class IndexAccess {
     IndexAccess(IndexAccess&&) = delete;
     IndexAccess& operator=(IndexAccess&&) = delete;
 
-    virtual ~IndexAccess() = default;
+    virtual ~IndexAccess() noexcept = default;
 
     virtual void dump() const = 0;
 
@@ -97,6 +97,14 @@ class IndexAccessDense : public IndexAccess<TValue> {
         IndexAccess<TValue>(fd) {
     }
 
+    IndexAccessDense(const IndexAccessDense&) = default;
+    IndexAccessDense& operator=(const IndexAccessDense&) = default;
+
+    IndexAccessDense(IndexAccessDense&&) = default;
+    IndexAccessDense& operator=(IndexAccessDense&&) = default;
+
+    ~IndexAccessDense() noexcept override = default;
+
     void dump() const override {
         index_type index{this->fd()};
 
@@ -136,6 +144,14 @@ class IndexAccessSparse : public IndexAccess<TValue> {
         IndexAccess<TValue>(fd) {
     }
 
+    IndexAccessSparse(const IndexAccessSparse&) = default;
+    IndexAccessSparse& operator=(const IndexAccessSparse&) = default;
+
+    IndexAccessSparse(IndexAccessSparse&&) = default;
+    IndexAccessSparse& operator=(IndexAccessSparse&&) = default;
+
+    ~IndexAccessSparse() noexcept override = default;
+
     void dump() const override {
         index_type index{this->fd()};
 

include/osmium/area/problem_reporter.hpp

@@ -80,7 +80,7 @@ namespace osmium {
             ProblemReporter(ProblemReporter&&) noexcept = default;
             ProblemReporter& operator=(ProblemReporter&&) noexcept = default;
 
-            virtual ~ProblemReporter() = default;
+            virtual ~ProblemReporter() noexcept = default;
 
             /**
              * Set the object the next problem reports will be on.

include/osmium/dynamic_handler.hpp

@@ -62,7 +62,7 @@ namespace osmium {
                 HandlerWrapperBase(HandlerWrapperBase&&) noexcept = default;
                 HandlerWrapperBase& operator=(HandlerWrapperBase&&) noexcept = default;
 
-                virtual ~HandlerWrapperBase() = default;
+                virtual ~HandlerWrapperBase() noexcept = default;
 
                 virtual void node(const osmium::Node& /*node*/) {
                 }
@@ -126,6 +126,14 @@ auto _name_##_dispatch(THandler& handler, const osmium::_type_& object, long) ->
                     m_handler(std::forward<TArgs>(args)...) {
                 }
 
+                HandlerWrapper(const HandlerWrapper&) = default;
+                HandlerWrapper& operator=(const HandlerWrapper&) = default;
+
+                HandlerWrapper(HandlerWrapper&&) noexcept = default;
+                HandlerWrapper& operator=(HandlerWrapper&&) noexcept = default;
+
+                ~HandlerWrapper() noexcept override = default;
+
                 void node(const osmium::Node& node) final {
                     node_dispatch(m_handler, node, 0);
                 }

include/osmium/index/detail/vector_map.hpp

@@ -65,6 +65,14 @@ namespace osmium {
                     m_vector() {
                 }
 
+                VectorBasedDenseMap(const VectorBasedDenseMap&) = default;
+                VectorBasedDenseMap& operator=(const VectorBasedDenseMap&) = default;
+
+                VectorBasedDenseMap(VectorBasedDenseMap&&) noexcept = default;
+                VectorBasedDenseMap& operator=(VectorBasedDenseMap&&) noexcept = default;
+
+                ~VectorBasedDenseMap() noexcept override = default;
+
                 explicit VectorBasedDenseMap(int fd) :
                     m_vector(fd) {
                 }
@@ -180,6 +188,14 @@ namespace osmium {
                     m_vector(fd) {
                 }
 
+                VectorBasedSparseMap(const VectorBasedSparseMap&) = default;
+                VectorBasedSparseMap& operator=(const VectorBasedSparseMap&) = default;
+
+                VectorBasedSparseMap(VectorBasedSparseMap&&) noexcept = default;
+                VectorBasedSparseMap& operator=(VectorBasedSparseMap&&) noexcept = default;
+
+                ~VectorBasedSparseMap() noexcept override = default;
+
                 void set(const TId id, const TValue value) final {
                     m_vector.push_back(element_type(id, value));
                 }

include/osmium/index/detail/vector_multimap.hpp

@@ -75,6 +75,14 @@ namespace osmium {
                     m_vector(fd) {
                 }
 
+                VectorBasedSparseMultimap(const VectorBasedSparseMultimap&) = default;
+                VectorBasedSparseMultimap& operator=(const VectorBasedSparseMultimap&) = default;
+
+                VectorBasedSparseMultimap(VectorBasedSparseMultimap&&) noexcept = default;
+                VectorBasedSparseMultimap& operator=(VectorBasedSparseMultimap&&) noexcept = default;
+
+                ~VectorBasedSparseMultimap() noexcept override = default;
+
                 void set(const TId id, const TValue value) final {
                     m_vector.push_back(element_type(id, value));
                 }

include/osmium/index/id_set.hpp

@@ -67,7 +67,7 @@ namespace osmium {
             IdSet(IdSet&&) noexcept = default;
             IdSet& operator=(IdSet&&) noexcept = default;
 
-            virtual ~IdSet() = default;
+            virtual ~IdSet() noexcept = default;
 
             /**
              * Add the given Id to the set.
@@ -383,6 +383,8 @@ namespace osmium {
 
         public:
 
+            ~IdSetSmall() noexcept override = default;
+
             /**
              * Add the given Id to the set.
              */

include/osmium/index/map.hpp

@@ -219,7 +219,7 @@ namespace osmium {
             MapFactory(MapFactory&&) = delete;
             MapFactory& operator=(MapFactory&&) = delete;
 
-            ~MapFactory() = default;
+            ~MapFactory() noexcept = default;
 
             static MapFactory<id_type, value_type>& instance() {
                 static MapFactory<id_type, value_type> factory;

include/osmium/index/map/dummy.hpp

@@ -56,6 +56,14 @@ namespace osmium {
 
                 Dummy() = default;
 
+                Dummy(const Dummy&) = default;
+                Dummy& operator=(const Dummy&) = default;
+
+                Dummy(Dummy&&) noexcept = default;
+                Dummy& operator=(Dummy&&) noexcept = default;
+
+                ~Dummy() noexcept override = default;
+
                 void set(const TId /*id*/, const TValue /*value*/) final {
                     // intentionally left blank
                 }